Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Xdebug 3 compatibility #285

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

sebastianfeldmann
Copy link
Contributor

In version 3 of Xdebug the function xdebug_disable got removed
so in order to support version 2 and 3 we have to make sure the
function exists before calling it.

In version 3 of Xdebug the function xdebug_disable got removed
so in order to support version 2 and 3 we have to make sure the
function exists before calling it.
@theseer
Copy link
Member

theseer commented Oct 24, 2020

Nice catch.

Do you happen to know if there's anything alternatively to do for xdebubg 3 instead?

The main point of calling xdebug_disable is (or was) to avoid the performance penalty having it enabled has. As far as I remember, one of the main points of xdebug 3 is to have almost zero performance impact when not in use.

@sebastianfeldmann
Copy link
Contributor Author

Yes Derick said it is no longer necessary and so he removed the functionality because if you do not used any Xdebug functionality you will not see any performance impact in version 3.

@theseer theseer merged commit 0052480 into phar-io:master Oct 24, 2020
@derickr
Copy link

derickr commented Oct 24, 2020

You'll see some performance impact as nothing comes for free! But it should be negligible. Benchmarks welcome :-)

@theseer
Copy link
Member

theseer commented Oct 24, 2020

Thanks for the heads up, @derickr 👍

@sebastianfeldmann
Copy link
Contributor Author

As soon as @theseer releases the new version I will do some tests comparing phive 0.14.4 and the latest Xdebug 2.x with phive 0.14.5 and the latest Xdebug 3 beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants