Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announcer could be used in BlText instead of BlTextAnnouncer #670

Open
plantec opened this issue Dec 11, 2024 · 2 comments
Open

Announcer could be used in BlText instead of BlTextAnnouncer #670

plantec opened this issue Dec 11, 2024 · 2 comments
Labels
text

Comments

@plantec
Copy link
Collaborator

plantec commented Dec 11, 2024

BlTextAnnouncer allow to prevent Announcement classes individually but this feature is not used and could be ported at Announcer level if we really need it.
plantec added a commit that referenced this issue Dec 12, 2024
@plantec
Remove almost all methods from BlTextAnnouncer (except #postCopy) (as…
d17cd27 
… a fix for #670)

Introduce BlElement>>focusHolder to allow an element to specify the element that should be focused when a focus is requested.
@plantec
Copy link
Collaborator Author

plantec commented Dec 13, 2024

BlTextAnnouncer is not removed for now because the method #postCopy remains. I wonder why Announcer doesn't have the same

@tinchodias tinchodias mentioned this issue Dec 13, 2024
Open
@tinchodias
Copy link
Collaborator

Maybe we suggest the change in Pharo. But did you check if Bloc actually copies the announcer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
text
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plantec @tinchodias