-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using ProfilerPresenter on code blocks #15772
Conversation
Jan could you rename the ProfilerPresenter StProfilerPresenter? Tx |
Of course. There are also multiple components of it, like ProfilerResultsPresenter, ProfilerTreeTablePresenter and many others, so I renamed them as well. Just note that the ProfilerPresenter is part of this Pharo repository, not https://github.com/pharo-spec/NewTools, where most of the St stuff is. |
@MarcusDenker should we move the profiler presenter to NewTools? |
Yes, I think that would make sense |
Ok, I have created issue for that (#15795) and will do it. |
You might want to look at #15792 and pharo-spec/NewTools#646 because I did started something, not much anyway. |
Thank you, but I, unfortunately, did not notice your PR in time and did the same thing anyway (along with removing the actual package and removing the baseline from So, I have proposed 3 PRs:
The order of accepting all is:
|
Thanks Jan. I will close my PR's then so we don't generate confusion. |
Allow using
ProfilerPresenter
on code blocks.Profile It
command in order to fix "ProfileIt" doesn't work #12137EDIT: