Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using ProfilerPresenter on code blocks #15772

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

JanBliznicenko
Copy link
Contributor

@JanBliznicenko JanBliznicenko commented Dec 11, 2023

Allow using ProfilerPresenter on code blocks.

EDIT:

  • added St prefixes to all the presenters

@Ducasse
Copy link
Member

Ducasse commented Dec 12, 2023

Jan could you rename the ProfilerPresenter StProfilerPresenter? Tx

@JanBliznicenko
Copy link
Contributor Author

JanBliznicenko commented Dec 12, 2023

Jan could you rename the ProfilerPresenter StProfilerPresenter? Tx

Of course. There are also multiple components of it, like ProfilerResultsPresenter, ProfilerTreeTablePresenter and many others, so I renamed them as well.

Just note that the ProfilerPresenter is part of this Pharo repository, not https://github.com/pharo-spec/NewTools, where most of the St stuff is.

@MarcusDenker MarcusDenker merged commit af06ed6 into pharo-project:Pharo12 Dec 13, 2023
1 of 2 checks passed
@hernanmd
Copy link
Member

@MarcusDenker should we move the profiler presenter to NewTools?

@MarcusDenker
Copy link
Member

Yes, I think that would make sense

@JanBliznicenko
Copy link
Contributor Author

Ok, I have created issue for that (#15795) and will do it.

@hernanmd
Copy link
Member

Ok, I have created issue for that (#15795) and will do it.

You might want to look at #15792 and pharo-spec/NewTools#646 because I did started something, not much anyway.

@JanBliznicenko
Copy link
Contributor Author

JanBliznicenko commented Dec 14, 2023

Ok, I have created issue for that (#15795) and will do it.

You might want to look at #15792 and pharo-spec/NewTools#646 because I did started something, not much anyway.

Thank you, but I, unfortunately, did not notice your PR in time and did the same thing anyway (along with removing the actual package and removing the baseline from BaselineOfIDE).

So, I have proposed 3 PRs:

The order of accepting all is:

  1. Accept (Re)Moved Profile It command pharo-spec/Spec#1491
  2. Accept (Re)Moved ProfilerUI package #15797
  3. Wait for new pharo image build to be done
  4. Re-run CI of Moved ProfilerUI here pharo-spec/NewTools#648
  5. Accept Moved ProfilerUI here pharo-spec/NewTools#648 (if CI is green)

@hernanmd
Copy link
Member

Thanks Jan. I will close my PR's then so we don't generate confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProfilerPresenter should be able to launch a profiling on a bloc "ProfileIt" doesn't work
4 participants