Refactor MenuItemMorph, PluggableMenuItemSpec and PragmaMenuAndShortcutRegistrationItem to support use of a FormSet and apply that to CmdCommand #16201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch answers a FormSet).
…ch held a Form, by an instance variable ‘iconFormSet’, which holds a FormSet.
…verride #defaultMenuIconName instead.
|
I converted this to a draft. Commit 02f48dc introduces a bug in |
Rinzwind
force-pushed
the
menuitemmorph-formset
branch
from
02f48dc
to
57ac5ef
Compare
…on’, which held a Form, by an instance variable ‘iconFormSet’, which holds a FormSet.
…nce variable ‘icon’, which held a Form, by an instance variable ‘iconFormSet’, which holds a FormSet.
…se the FormSet for the icon.
…mand to ‘menuItem’ (#doRegisterContextMenuItemsFor:withBuilder: on CmdCommand sends #setUpIconForMenuItem: with a PragmaMenuAndShortcutRegistration, rather than a MenuItemMorph, as the argument).
|
I fixed the bug referred to in my previous message by first refactoring PluggableMenuItemSpec and PragmaMenuAndShortcutRegistrationItem as well. |
Rinzwind
changed the title
jecisc
requested changes
Feb 19, 2024
| @@ -13,6 +13,7 @@ Class { | |||
| 'label', | |||
| 'help', | |||
| 'icon', | |||
There was a problem hiding this comment.
This instance variable is not used anymore and should be removed
There was a problem hiding this comment.
Forgot to actually remove it indeed, fixed in commit 49a7a88.
jecisc
added
the
Status: Need more work
…utRegistrationItem to replace the instance variable ‘icon’ […] by […] ‘iconFormSet’ […]”): ‘icon’ was not actually removed.
|
@jecisc can you check it? Tx |
|
@jecisc Could I ask for an update on the (re)review? If you’re not available, it might be better to let someone else take over? |
jecisc
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors MenuItemMorph to support use of a FormSet for the icon and applies that to the CmdCommand hierarchy. In the CmdCommand hierarchy, the overrides of
#defaultMenuIconare refactored to override#defaultMenuIconNameinstead.