Merge pull request #968 from Ducasse/noGlamorousIconNames

No glamorous icon names
pharo-spec · Jan 29, 2025 · 439cfb1 · 439cfb1
2 parents 612a06e + b8548ae
commit 439cfb1
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 20 deletions.
diff --git a/src/NewTools-Scopes-Editor/ScopeNodesPresenter.class.st b/src/NewTools-Scopes-Editor/ScopeNodesPresenter.class.st
@@ -110,12 +110,12 @@ ScopeNodesPresenter >> argumentsListActions [
 	^ SpActionGroup new
 		addActionWith: [ :anItem | anItem
 			name: 'Check all Cmd-a';
-			iconName: #glamorousAccept;
+			iconName: #accept;
 			action: [ self checkAll ] ];
 		addActionWith: [ :anItem | anItem
 			name: 'Unheck all';
 			shortcutKey: $u actionModifier;
-			iconName: #glamorousAccept;
+			iconName: #accept;
 			action: [ self uncheckAll ] ];
 		addActionWith: [ :anItem | anItem
 			name: 'Add class hierarchy (flattened)';
@@ -125,12 +125,12 @@ ScopeNodesPresenter >> argumentsListActions [
 		addActionWith: [ :anItem | anItem
 			name: 'Browse';
 			actionEnabled: [ scopeNodesTree selectedItem isNotNil ];
-			iconName: #glamorousBrowse;
+			iconName: #browse;
 			action: [ self browseSelectedItem ] ];
 		addActionWith: [ :anItem | anItem
   			name: 'Class references';
   			actionEnabled: [ scopeNodesTree selectedItem isClassNode ];
-  			iconName: #glamorousBrowse;
+  			iconName: #browse;
   			action: [ self showReferencesToClass: scopeNodesTree selectedItem value ] ];
 		addShortcutWith: [ :action | action 
 			shortcutKey: $a actionModifier;

diff --git a/src/NewTools-Scopes-Editor/ScopesPresenter.class.st b/src/NewTools-Scopes-Editor/ScopesPresenter.class.st
@@ -89,20 +89,20 @@ ScopesPresenter >> argumentsListActions [
 		addActionWith: [ :anItem | anItem
 			name: 'Delete';
 			actionEnabled: [ scopesTree selectedItem isScopeNode ];
-			iconName: #glamorousTrash;
+			iconName: #trash;
 			action: [ self deleteSelectedScope ] ];
 		addActionWith: [ :anItem | anItem
 			name: 'Edit';
 			actionEnabled: [ scopesTree selectedItem isScopeNode ];
-			iconName: #glamorousEdit;
+			iconName: #edit;
 			action: [ self editSelectedScope ] ];
 		addActionWith: [ :anItem | anItem
 			name: 'Rename';
 			actionEnabled: [ scopesTree selectedItem isScopeNode ];
 			action: [ self renameSelectedScope ] ];
 		addActionWith: [ :anItem | anItem
 			name: 'Inspect';
-			iconName: #glamorousSearch;
+			iconName: #search;
 			action: [ scopesTree selectedItem inspect ] ];
 		addActionWith: [ :anItem | anItem
 			name: 'Open in browser';
@@ -111,7 +111,7 @@ ScopesPresenter >> argumentsListActions [
 		addActionWith: [ :anItem | anItem 
 			name: 'Browse';
 			actionEnabled: [ scopesTree selectedItem isScopeNode not ];
-			iconName: #glamorousBrowse;
+			iconName: #browse;
 			action: [ self browseSelectedItem ] ];
 		addActionWith: [ :anItem | anItem
 			name: 'Class references';

diff --git a/src/NewTools-SettingsBrowser/StSettingsMainPresenter.class.st b/src/NewTools-SettingsBrowser/StSettingsMainPresenter.class.st
@@ -217,13 +217,6 @@ StSettingsMainPresenter >> initializePresenters [
 	self initializeFocus.
 ]
 
-{ #category : 'initialization' }
-StSettingsMainPresenter >> initializeWindow: aWindowPresenter [
-
-	super initializeWindow: aWindowPresenter.
-	aWindowPresenter centered
-]
-
 { #category : 'loading' }
 StSettingsMainPresenter >> loadSettings [
 	"Load the settings from the system settings file, if exists"

diff --git a/src/NewTools-Spotter/StSpotter.class.st b/src/NewTools-Spotter/StSpotter.class.st
@@ -81,8 +81,8 @@ StSpotter class >> createTips [
 StSpotter class >> defaultPreferredExtent [
 
 	^ self isShowingPreview 
-		ifTrue: [ (750@850) ]
-		ifFalse: [ (500@850) ]
+		ifTrue: [ (750@680) ]
+		ifFalse: [ (500@680) ]
 ]
 
 { #category : 'accessing' }
@@ -556,7 +556,7 @@ StSpotter >> initializeWindow: aWindowPresenter [
 	aWindowPresenter 
 		title: 'Spotter';
 		withoutDecorations;
-		initialExtent: self initialExtent;
+		initialExtent: self preferredExtent;
 		whenOpenedDo: [ self startProcessing ];
 		whenClosedDo: [ 
 			self stopProcessing.

diff --git a/src/NewTools-WelcomeBrowser/StWelcomeBrowser.class.st b/src/NewTools-WelcomeBrowser/StWelcomeBrowser.class.st
@@ -221,8 +221,7 @@ StWelcomeBrowser >> initializeWindow: aWindowPresenter [
 	super initializeWindow: aWindowPresenter.
 	aWindowPresenter
 		bindKeyCombination: Character arrowRight asKeyCombination toAction: [ self selectNext ]; 
-		bindKeyCombination: Character arrowLeft asKeyCombination toAction: [ self selectPrevious ]; 
-		centered
+		bindKeyCombination: Character arrowLeft asKeyCombination toAction: [ self selectPrevious ]
 ]
 
 { #category : 'accessing - contents' }