Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup-AbstractTool #523

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

MarcusDenker
Copy link
Contributor

Rewrite all users of AbstractTool, move some feature to SystemNavigation (which is a horrible thing, too).

But this way we have one strange things removed (AbstractTool)

  • rewrite users of lookupVar:declare:

…ion (which is a horrible thing, too).

But this way we have one strange things removed (AbstractTool)

- rewrite users of lookupVar:declare:
-
MarcusDenker added a commit to MarcusDenker/pharo that referenced this pull request May 12, 2023
@Ducasse
Copy link
Contributor

Ducasse commented May 13, 2023

I read the changes and it is unclear to me why self model is worse than SystemNavigation new.
I could not understand why AbstractTool is bad either.
Now we can proceed and integrate these changes.

@MarcusDenker
Copy link
Contributor Author

the model then was just forwarding to SystemNavigation for these methods

AbstractTool is just used by old tools.. e.g. the inspector or debugger do no use it. Just ChangeSorter (it's model was a subclass), MessageList (which was just doing AbstractTool new) and the too for Manifest (it's model was a subclass of AbstractTool).

We need something, but just one abstraction. This step removes AbstractTool, as the code was strange and it was mostly just forwarding to SystemNavigation. We then need to continue, e.g SystemNavigation with all the UI related methods is very strange.

@estebanlm estebanlm merged commit decdb68 into pharo-spec:Pharo12 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants