Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling to selection when selecting path to the receiver class in the meta browser (Fix for the meta browser in the inspector) #597

Merged

Conversation

adri09070
Copy link
Contributor

Fixes pharo-project/pharo#14863

In StMetaBrowser, at the initialization, it selects the path to the class of the selected object

StMetaBrowserPresenter>>#initializePresenters
  ...
  classes selectPath: (Array new: classHierarchy size withAll: 1)

However, if the meta browser is too small, it would result in not showing the receiver class (and not even showing a scrollbar to get to it). This is the case in the debugger inspector which is smaller than the normal inspector (but I guess it would appear in the normal inspector if you have class hierearchy with big depths):

image

I fixed it so that it automatically scrolls to the receiver class because it is (generally) the class of interest:

StMetaBrowserPresenter>>#initializePresenters
  	classes
		selectPath: (Array new: classHierarchy size withAll: 1)
		scrollToSelection: true

And now the scrollbar appears correctly and everything is fine: even in the debugger inspector

image

@jecisc jecisc merged commit 44c941f into pharo-spec:Pharo12 Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger inspector does not show the class of my object
2 participants