Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler stack items #632

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

StevenCostiou
Copy link
Member

Changed the debugger stack from a table to a list.
All features are conserved.

Capture d’écran 2023-11-30 à 14 07 26

@StevenCostiou
Copy link
Member Author

Note that I don't like the package.
In my opinion that still improves the space usage.
Decision about the package can be taken later.

@StevenCostiou
Copy link
Member Author

I also changed the icon for unsaved changes in the stack.

Capture d’écran 2023-11-30 à 14 09 47

@jecisc
Copy link
Member

jecisc commented Nov 30, 2023

I really like to have the stack higher like this! I spend a lot of time scrolling it usually

@StevenCostiou
Copy link
Member Author

I really like to have the stack higher like this! I spend a lot of time scrolling it usually

There is that waiting for merge then ;) #630
With both that one and this one it renders nice.

@StevenCostiou
Copy link
Member Author

So actually this one should be merged first

@StevenCostiou
Copy link
Member Author

ok too late xD
The CI will fail I will fix it

@jecisc
Copy link
Member

jecisc commented Nov 30, 2023

So actually this one should be merged first

Too late sorry :( Since the other one was approved and green I merged it

@StevenCostiou
Copy link
Member Author

well, seems good...

@MarcusDenker MarcusDenker merged commit 3c8642d into pharo-spec:Pharo12 Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants