Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test debugger does not log exceptions twice when opened #643

Merged

Conversation

hernanmd
Copy link
Member

@hernanmd hernanmd commented Dec 8, 2023

Add a test for PR in Pharo, to check that when the log debugger stack to file setting is false, a Pharo log file is not created when requesting a debugger.

Hernán Morales Durand added 2 commits December 8, 2023 19:55
Copy link
Contributor

@adri09070 adri09070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is really nice to have, thanks!

Just one remark though:

If the test fails, it will not set back the debuggingStackToFile setting. Maybe, the assignment should be done in an ensure: block or maybe it should be set in the tearDown:

src/NewTools-Debugger-Tests/StDebuggerTest.class.st Outdated Show resolved Hide resolved
@adri09070 adri09070 merged commit a3380fa into pharo-spec:Pharo12 Jan 19, 2024
1 of 2 checks passed
@hernanmd hernanmd deleted the add_debugger_test_log_twice_fix branch July 6, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants