Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor various ‘worldMenu’ registration methods to use #iconName: instead of #icon: #711

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Refactor various ‘worldMenu’ registration methods to use #iconName: instead of #icon: #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/NewTools-CodeCritiques/StCritiqueBrowserPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ StCritiqueBrowserPresenter class >> critiquesBrowserMenuOn: aBuilder [
order: 2;
parent: #Browsing;
help: 'To manage rule checks.';
icon: self icon
iconName: self iconName
]

{ #category : 'layout' }
Expand Down Expand Up @@ -72,7 +72,13 @@ StCritiqueBrowserPresenter class >> icon [

"Answer an icon for the receiver."

^ self iconNamed: #error
^ self iconNamed: self iconName
]

{ #category : 'icons' }
StCritiqueBrowserPresenter class >> iconName [

^ #error
]

{ #category : 'instance creation' }
Expand Down
2 changes: 1 addition & 1 deletion src/NewTools-Playground/StPlaygroundPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ StPlaygroundPresenter class >> menuCommandOn: aBuilder [
order: 1;
keyText: 'o, w';
help: 'A window used as a scratchpad area where fragments of Pharo code can be entered, stored, edited, and evaluated.';
icon: (self iconNamed: #workspace)
iconName: #workspace
]

{ #category : 'instance creation' }
Expand Down
2 changes: 1 addition & 1 deletion src/NewTools-ProfilerUI/StProfilerPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ StProfilerPresenter class >> menuCommandOn: aBuilder [
(aBuilder item: #'Profiler')
parent: #Profiling;
order: 1;
icon: (self iconNamed: #smallProfile);
iconName: #smallProfile;
help: 'Profile the execution of a piece of code using different profilers, and navigate into the result.';
action: [self new open]
]
Expand Down
2 changes: 1 addition & 1 deletion src/NewTools-RewriterTools/StRewriterExpressionFinderPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ StRewriterExpressionFinderPresenter class >> menuCommandOn: aBuilder [
action: [ self new open ];
order: 31;
parent: #Tools;
icon: self icon;
iconName: self iconName;
help: self descriptionText
]

Expand Down
2 changes: 1 addition & 1 deletion src/NewTools-RewriterTools/StRewriterMatchToolPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ StRewriterMatchToolPresenter class >> menuCommandOn: aBuilder [
order: 32;
parent: #Tools;
help: self descriptionText;
icon: self icon
iconName: self iconName
]

{ #category : 'specs' }
Expand Down
2 changes: 1 addition & 1 deletion src/NewTools-RewriterTools/StRewriterRuleEditorPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ StRewriterRuleEditorPresenter class >> menuCommandOn: aBuilder [
order: 30;
parent: #Tools;
help: self descriptionText;
icon: self icon
iconName: self iconName
]

{ #category : 'specs' }
Expand Down
2 changes: 1 addition & 1 deletion src/NewTools-SettingsBrowser/StSettingsApplication.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ StSettingsApplication class >> menuSettingsBrowserCommandOn: aBuilder [
parent: #Tools;
label: 'New Settings Browser';
action: [ self new run ];
icon: (self iconNamed: self taskbarIconName);
iconName: self taskbarIconName;
help: 'New Settings Browser';
order: 100
]
Expand Down
Loading