Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-filling the name text presenter in file dialogs #717

Conversation

hernanmd
Copy link
Member

@hernanmd hernanmd commented Mar 12, 2024

This PR enables to preset the "name text" presenter text, which is useful for example to suggest a new file name in Save File dialogs. It also preserves the feature of updating the text when a directory or file is changed in the file navigation table.

Add tests.

Usage example:

StSaveFilePresenter new
		title: 'Save Microdown document';
		nameText: 'mydocument.' , anExtension asString;
		extensions: { anExtension }; 
		openModal.

@hernanmd hernanmd self-assigned this Mar 12, 2024
@hernanmd hernanmd added the enhancement New feature or request label Mar 12, 2024
@hernanmd hernanmd requested a review from Ducasse March 12, 2024 20:51
@hernanmd
Copy link
Member Author

Failing test unixLibraryName is not related.

@hernanmd hernanmd requested review from demarey and jecisc March 13, 2024 16:13
@jecisc jecisc merged commit 1cbb5a8 into pharo-spec:Pharo12 Mar 14, 2024
1 of 2 checks passed
@hernanmd hernanmd deleted the enable_set_filename_in_file_browser_dialogs branch July 6, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants