Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic event support for setting events #881

Open
wants to merge 26 commits into
base: Pharo13
Choose a base branch
from

Conversation

hernanmd
Copy link
Member

@hernanmd hernanmd commented Nov 7, 2024

Notes

This PR needs pharo-project/pharo#17350 to be integrated in the Pharo image

Details

Introduces the following updates:

  • Get the real value when getting a setting presenter from a setting declaration.
  • Announce SettingUpdated on checkboxes only if the setting effectively changed.
  • Fix checkboxes items always opening with the default value instead of the real value.
  • Add announcer support in StSettingPresenterItem

…claration.

Announce SettingUpdated on checkboxes only if the setting effectively changed.
Fix checkboxes items always opening with the default value instead of the real value.
Add announcer support in StSettingPresenterItem
@hernanmd hernanmd self-assigned this Nov 7, 2024
@hernanmd hernanmd added the enhancement New feature or request label Nov 7, 2024
@jecisc
Copy link
Member

jecisc commented Nov 18, 2024

StSettingsTrackerTest
 ✗ #testSettingUpdated (12ms)
TestFailure: Assertion failed
StSettingsTrackerTest(TestAsserter)>>assert:description:resumable:
StSettingsTrackerTest(TestAsserter)>>assert:description:
StSettingsTrackerTest(Object)>>assert:
[ : ann |
		self assert: (tracker changedSettings includes: ann) ] in StSettingsTrackerTest>>testSettingUpdated ...assert: (tracker changedSettings includes: ann)
FullBlockClosure(BlockClosure)>>cull:
[ :ann |
			numberOfAnnouncements := numberOfAnnouncements + 1.
			aBlock cull: ann ] in StSettingsTrackerTest>>when:do:
FullBlockClosure(BlockClosure)>>cull:
FullBlockClosure(BlockClosure)>>cull:cull:
[ action cull: anAnnouncement cull: announcer ] in AnnouncementSubscription(AbstractAnnouncementSubscription)>>deliver:

@jecisc jecisc added the need more work This needs to be improved before being considered label Nov 18, 2024
@hernanmd hernanmd removed the need more work This needs to be improved before being considered label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants