-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic event support for setting events #881
Open
hernanmd
wants to merge
26
commits into
pharo-spec:Pharo13
Choose a base branch
from
hernanmd:p13-settings-browser-support
base: Pharo13
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add basic event support for setting events #881
hernanmd
wants to merge
26
commits into
pharo-spec:Pharo13
from
hernanmd:p13-settings-browser-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…claration. Announce SettingUpdated on checkboxes only if the setting effectively changed. Fix checkboxes items always opening with the default value instead of the real value. Add announcer support in StSettingPresenterItem
jecisc
reviewed
Nov 7, 2024
… settingTree already present in the application's properties. Announce SettingUpdated on checkboxes only if the setting effectively changed. Fix checkboxes items always opening with the default value instead of the real value.
|
jecisc
added
the
need more work
This needs to be improved before being considered
label
Nov 18, 2024
Simple registration of updated events for now.
Add tests. Use 1-arg blocks for announcing updates.
Add confirm question before overwriting system settings.
…ion because cannot reproduce the bug in the image)
hernanmd
removed
the
need more work
This needs to be improved before being considered
label
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR needs pharo-project/pharo#17350 to be integrated in the Pharo image
Details
Introduces the following updates: