Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to npm install #262

Closed
himerus opened this issue Mar 14, 2018 · 3 comments
Closed

Unable to npm install #262

himerus opened this issue Mar 14, 2018 · 3 comments

Comments

@himerus
Copy link
Contributor

himerus commented Mar 14, 2018

After doing a checkout of latest master, running npm install resulted in the following issue:

Summary

npm WARN stylelint-webpack-plugin@0.10.3 requires a peer of stylelint@^8.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN stylelint-webpack-plugin@0.10.3 requires a peer of webpack@^3 || ^2 || ^2.2.0-rc.0 || ^2.1.0-beta.0 || ^1.13.2 but none is installed. You must install peer dependencies yourself.

Reproduction steps

git clone git@github.com:phase2/particle.git
cd particle
npm install

Proposed fix

Installing styelint and weback (latest) both globally and in project had no effect on this error.

I've forked and tested the stylelint-webpack-plugin at himerus/stylelint-webpack-plugin@76aa875

This update to the peerDependencies in package.json seemed to fix the issue of me not being able to install.
I presume this should be posted upstream to https://github.com/waterfoul/stylelint-webpack-plugin, but wanted some verification I wasn't the only one that had seen this.

@tjheffner
Copy link
Contributor

Thanks for the report, we are aware of these warnings. I'm curious, are they actually breaking your install? Are npm run setup and npm run start failing? I've been treating these warnings as noise so far because the stylelint-webpack-plugin is not yet updated for webpack 4 support. webpack-contrib/stylelint-webpack-plugin#139

The maintainer for stylelint-webpack-plugin has stated he's planning to rewrite the module to conform to webpack4 standards (webpack-contrib/stylelint-webpack-plugin#140) but until that happens i've been taking the path of least resistance to get things running.

@himerus
Copy link
Contributor Author

himerus commented Mar 14, 2018

That's odd, I swear it didn't let me run npm run setup / start initially, but when I grab this in a clean checkout, yes, they are indeed JUST warnings.

@tjheffner
Copy link
Contributor

In that case, I'm going to close this. It is noise but should be going away in the next few weeks, pending upstream updates to the stylelint-webpack-plugin. Thanks again for reporting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants