Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack4 support; #140

Closed
wants to merge 4 commits into from
Closed

Add webpack4 support; #140

wants to merge 4 commits into from

Conversation

KyKyPy3
Copy link

@KyKyPy3 KyKyPy3 commented Mar 4, 2018

Providing ability to run on webpack 4

@KyKyPy3
Copy link
Author

KyKyPy3 commented Mar 4, 2018

#137

@coveralls
Copy link

coveralls commented Mar 4, 2018

Coverage Status

Coverage decreased (-4.6%) to 94.118% when pulling e856173 on KyKyPy3:master into 04e0f69 on JaKXz:master.

@mtraynham
Copy link

@KyKyPy3 this does seem like the appropriate solution to upgrading to Webpack 4, but you've changed the package.json name and urls. Not sure if you meant to do that within this PR. Either way, this will still complain about Webpack versioning.

Might I suggest moving your last commit into a personal branch and adding a new commit here for the peerDependency version fix.

@KyKyPy3
Copy link
Author

KyKyPy3 commented Mar 5, 2018

Done

Copy link
Contributor

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

I will probably be rewriting this plugin with babel soon, and adding the optional chaining plugin.

In the meantime this will need to also cover the LintDirtyModulesPlugin as well.

@stevenleija
Copy link

Is there an ETA on when this gets merged and published?

@mgoodings
Copy link

Whilst waiting for this to be updated and until the rewrite from @JaKXz is available I've created a simplistic plugin that supports Webpack 4.

https://github.com/mgoodings/easy-stylelint-plugin

pipa added a commit to pipa/hive-front that referenced this pull request Mar 25, 2018
Added css lint but the plugin is still not working with webpack 4,
so I'll wait for the plugin to update. See: webpack-contrib/stylelint-webpack-plugin#140
@jsf-clabot
Copy link

jsf-clabot commented Mar 27, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shellscape
❌ Efremenko Roman


Efremenko Roman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@shellscape
Copy link
Contributor

@KyKyPy3 this project has just moved into the webpack-contrib org. We'd very much like to merge your PR but we'll need you to sign the CLA first (see above).

@shellscape
Copy link
Contributor

As we could not get ahold of the author of this PR, we have created #144.

@shellscape shellscape closed this Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants