-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webpack4 support; #140
Conversation
@KyKyPy3 this does seem like the appropriate solution to upgrading to Webpack 4, but you've changed the Might I suggest moving your last commit into a personal branch and adding a new commit here for the peerDependency version fix. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
I will probably be rewriting this plugin with babel soon, and adding the optional chaining plugin.
In the meantime this will need to also cover the LintDirtyModulesPlugin
as well.
Is there an ETA on when this gets merged and published? |
Whilst waiting for this to be updated and until the rewrite from @JaKXz is available I've created a simplistic plugin that supports Webpack 4. |
Added css lint but the plugin is still not working with webpack 4, so I'll wait for the plugin to update. See: webpack-contrib/stylelint-webpack-plugin#140
Efremenko Roman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
@KyKyPy3 this project has just moved into the |
As we could not get ahold of the author of this PR, we have created #144. |
Providing ability to run on webpack 4