Add spinner support to rig project sync[:stop] #141
Conversation
Corrected a few more references to rig, and elaborated the build script.
Release 1.2.0
1.2.1 release
1.2.2 Release
1.2.3 Release
Version 1.3.0
Version 1.3.1
1.3.2 Release
2.0.0 release
| if err := util.Command("docker", "volume", "create", volumeName).Run(); err != nil { | ||
| return cmd.Failure(fmt.Sprintf("Failed to create sync volume: %s", volumeName), "VOLUME-CREATE-FAILED", 13) | ||
| } | ||
|
|
||
| cmd.out.Info("Starting Unison container") | ||
| cmd.out.Info("Sync volume '%s' created", volumeName) |
There was a problem hiding this comment.
I never see this message, even recording and playing in slow motion.
There was a problem hiding this comment.
On further testing, I don't see it without verbose mode but I do see it in verbose mode.
| @@ -283,7 +286,7 @@ func (cmd *ProjectSync) LoadComposeFile() (*ComposeFile, error) { | |||
| // when compiled without -cgo this executable will not use the native mac dns resolution | |||
| // which is how we have configured dnsdock to provide names for containers. | |||
| func (cmd *ProjectSync) WaitForUnisonContainer(containerName string, timeoutSeconds int) (string, error) { | |||
| cmd.out.Info("Waiting for container to start") | |||
| cmd.out.SpinWithVerbose("Sync container '%s' started , waiting for unison server process...", containerName) | |||
There was a problem hiding this comment.
Ignore this, I wasn't supposed to because I was running in non verbose mode. It's there in verbose mode.
|
I dropped a few notes about where I don't see messages though I consider that not particularly blocking. Here is the sequence I see: |
|
One other thing I noticed (which I also don't think needs to block) is the error message doesn't work as nicely as the success messages do. Since the message is getting returned however it doesn't seem to be as simple as swapping it to a logger message. Perhaps doing a log message and then returning the error?
|
|
Adjusted error message to work better with spinner
|
This is a first take, I think there's some language and formatting tightening potential, but it all seems to work as you'd expect.