Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed $HOME from volume mount #23

Merged
merged 2 commits into from
Mar 21, 2017
Merged

Removed $HOME from volume mount #23

merged 2 commits into from
Mar 21, 2017

Conversation

febbraro
Copy link
Member

Turns out it works just fine removing home, that is only needed if we want to use TLS, which, for now, we don't need to do.

@febbraro febbraro requested review from tekante and grayside March 21, 2017 19:14
grayside
grayside approved these changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just have to trust your testing. This seems fine to me.

@febbraro
Copy link
Member Author

Joanna is working on a facelift for the Dashboard frontend too. :)

@febbraro febbraro merged commit 9e4f340 into develop Mar 21, 2017
@febbraro febbraro deleted the bug/dashboard-home-readonly branch March 21, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside approved these changes

@tekante tekante Awaiting requested review from tekante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@febbraro @grayside