Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.2 Release #24

Merged
merged 6 commits into from
Mar 21, 2017
Merged

1.2.2 Release #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed316f3
Update README.md
danshumaker Mar 15, 2017
3555ff0
Merge pull request #22 from danshumaker/patch-1
febbraro Mar 15, 2017
4c75938
Mount the home directory read only
febbraro Mar 21, 2017
626c205
Removed volume mount of HOME entirely, defaults work just fine
febbraro Mar 21, 2017
9e4f340
Merge pull request #23 from phase2/bug/dashboard-home-readonly
febbraro Mar 21, 2017
61aaef6
Version bump
febbraro Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.2.2

- Removed the $HOME volume mount for the Dashboard

## 1.2.1

- Support the Docker version numbering change
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ godep restore
Code
----

We make use a few key libraries to do all the fancy stuff that the `rig` CLI will do.
We make use of a few key libraries to do all the fancy stuff that the `rig` CLI will do.

* https://github.com/urfave/cli
* The entire CLI framework from helps text to flags. This was an easy cli to build b/c of this library
Expand Down
4 changes: 0 additions & 4 deletions cli/commands/dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package commands

import (
"fmt"
"os"
"os/exec"
"runtime"

Expand Down Expand Up @@ -37,8 +36,6 @@ func (cmd *Dashboard) Run(c *cli.Context) error {
func (cmd *Dashboard) LaunchDashboard(machine Machine) {
machine.SetEnv()

home := os.Getenv("HOME")

exec.Command("docker", "stop", "outrigger-dashboard").Run()
exec.Command("docker", "rm", "outrigger-dashboard").Run()

Expand All @@ -48,7 +45,6 @@ func (cmd *Dashboard) LaunchDashboard(machine Machine) {
"run",
"-d",
"--restart=always",
"-v", fmt.Sprintf("%s:%s", home, home),
"-v", "/var/run/docker.sock:/var/run/docker.sock",
"-l", "com.dnsdock.name=dashboard",
"-l", "com.dnsdock.image=outrigger",
Expand Down
2 changes: 1 addition & 1 deletion cli/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"github.com/urfave/cli"
)

const VERSION = "1.2.1"
const VERSION = "1.2.2"

// It all starts here
func main() {
Expand Down