Tilemap#paste diffX and diffY equations changed #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Clay.io's HTML5 Virtual Game Controller
Added touch joystick example
Conflicts: README.md
photonstorm
added a commit
that referenced
this pull request
Feb 12, 2014
Tilemap#paste diffX and diffY equations changed
photonstorm
added a commit
that referenced
this pull request
Feb 12, 2014
…er window (thanks georgiee) Added TimerEvent.pendingDelete and checks in Timer.update, so that removing an event in a callback no longer throws an exception (thanks georgiee) Fixed TypeScript defs on lines 1741-1748 (thanks wombatbuddy) Added SAT.js to TypeScript definition. Now compiles properly. Added missing Line.js to the Grunt file. Tilemap#paste diffX and diffY equations changed, fixed issue #393 (thanks brejep) Added missing return value in Body.hitLeft and hitRight, fixes issue #398 (thanks ram64). Fixed easing tween example case. Issue #379 (thanks wesleywerner) Removed SAT.js UMD wrapped, fixes issue #361 (thanks luizbills)
photonstorm
added a commit
that referenced
this pull request
Feb 12, 2014
…er window (thanks georgiee) Added TimerEvent.pendingDelete and checks in Timer.update, so that removing an event in a callback no longer throws an exception (thanks georgiee) Fixed TypeScript defs on lines 1741-1748 (thanks wombatbuddy) Added SAT.js to TypeScript definition. Now compiles properly. Added missing Line.js to the Grunt file. Tilemap#paste diffX and diffY equations changed, fixed issue #393 (thanks brejep) Added missing return value in Body.hitLeft and hitRight, fixes issue #398 (thanks ram64). Fixed easing tween example case. Issue #379 (thanks wesleywerner) Removed SAT.js UMD wrapped, fixes issue #361 (thanks luizbills) Removed inContact check from Body.separate. Fixed Tilemap docs (wrongly pointed to Tileset methods)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should correct an issue with copying and pasting sections of tilemaps to different x/y coordinates. Relates to this forum post: http://www.html5gamedevs.com/topic/3367-tilemap-copy-paste-issues/
I've added a QUnit test for this change. As it is dealing with data manipulation I found it useful.
The tests highlighted another possible issue with tilemap copy and paste. Changing data in copied data will actually change the tilemap it is copied from. This is because the copy creates an array with the same tile references as the actual tilemap. Not sure of the best solution there as memory could be an issue.
I'd be interested in contributing further to Phaser and I was wondering if adding some more unit tests might be useful, what are your thoughts?