Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error when cycles doesn't match #18

Merged
merged 2 commits into from
Dec 24, 2024
Merged

No error when cycles doesn't match #18

merged 2 commits into from
Dec 24, 2024

Conversation

sjalander
Copy link
Collaborator

No description provided.

@sjalander sjalander requested review from phate and haved December 20, 2024 10:51
haved
haved previously approved these changes Dec 20, 2024
Copy link
Collaborator

@haved haved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now, I wish GitHub would implement actions/runner#2347, but it is 2.5 years old by now

Copy link
Owner

@phate phate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get a FIXME comment on this as well so we know why it returns 0 instead of 1. This will otherwise be forgotten.

@phate
Copy link
Owner

phate commented Dec 24, 2024

@sjalander Ping

@phate phate merged commit 63c77ee into main Dec 24, 2024
1 check passed
@phate phate deleted the cycles branch December 24, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants