Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scientific notation can also contain '.' #82

Closed
shagkur opened this issue Jan 18, 2022 · 7 comments
Closed

Scientific notation can also contain '.' #82

shagkur opened this issue Jan 18, 2022 · 7 comments
Assignees
@phax
Labels
enhancement

Comments

@shagkur
Copy link
Contributor

shagkur commented Jan 18, 2022

Example:
1.5e-05 is also perfectly valid. see: https://en.wikipedia.org/wiki/Scientific_notation
shagkur added a commit to unblu/ph-css that referenced this issue Jan 18, 2022
@shagkur
phax#82 fix rule to respect '.' in scientific notation
e463771
@shagkur
Copy link
Contributor Author

shagkur commented Jan 18, 2022

PR: #83

@phax phax self-assigned this Jan 18, 2022
@phax
Copy link
Owner

phax commented Jan 18, 2022

You are so right - thx

@shagkur
Copy link
Contributor Author

shagkur commented Jan 18, 2022

Wait with applying the PR. need to check again the rule

@phax
Copy link
Owner

phax commented Jan 18, 2022

The order of the rules in the JJT file might be relevant - that was already tricky previously....

@shagkur
Copy link
Contributor Author

shagkur commented Jan 18, 2022

Okay. Well it rather seems that i missed the SPLIT_NUMBER regex in CSSParserHelper. The value from the test is parsed correctly.

shagkur added a commit to unblu/ph-css that referenced this issue Jan 18, 2022
@shagkur
phax#82 also respect regex in parser helper
72d6b04
@shagkur
Copy link
Contributor Author

shagkur commented Jan 18, 2022

Sorted.

@phax
Copy link
Owner

phax commented Jan 18, 2022

Part of 6.4.4 release

@phax phax closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phax phax

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phax @shagkur