Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for extension elements on EndpointTyp #74

Closed
Martijn-ATO opened this issue Jun 25, 2018 · 6 comments
Closed

Support for extension elements on EndpointTyp #74

Martijn-ATO opened this issue Jun 25, 2018 · 6 comments
Assignees
Milestone

Comments

@Martijn-ATO
Copy link

The SMP specification allows extensions at several points in the XML schema for service metadata. The project I am currently working on requires an extension on the EndpointType to allow for metadata about corner 3.

We are kindly requesting if it would be possible to add support for this in your awesome product :-)

The current method of adding extension elements to Service Group would suffice.

<xs:complexType name="EndpointType">
xs:sequence
<xs:element name="EndpointURI" type="xs:anyURI"/>
<xs:element name="RequireBusinessLevelSignature" type="xs:boolean" minOccurs="0" default="false"/>
<xs:element name="MinimumAuthenticationLevel" type="xs:string" minOccurs="0"/>
<xs:element name="ServiceActivationDate" type="xs:dateTime" minOccurs="0"/>
<xs:element name="ServiceExpirationDate" type="xs:dateTime" minOccurs="0"/>
<xs:element name="Certificate" type="xs:base64Binary"/>
<xs:element name="ServiceDescription" type="xs:string"/>
<xs:element name="TechnicalContactUrl" type="xs:anyURI"/>
<xs:element name="TechnicalInformationUrl" type="xs:anyURI" minOccurs="0"/>
<xs:element name="Extension" type="ExtensionType" minOccurs="0" maxOccurs="unbounded"/>
</xs:sequence>
<xs:attribute name="transportProfile" type="xs:string" use="required"/>
</xs:complexType>

@phax phax self-assigned this Jun 25, 2018
@phax phax added this to the v5.0.7 milestone Jun 25, 2018
@phax phax closed this as completed Jun 25, 2018
@Martijn-ATO
Copy link
Author

Hi Philip,

I can create an Endpoint with one extension and the REST response shows the Extension element. But when I edit the Endpoint, the contents of the extension is not populated in the textarea for Extension. When I add content and save the Endpoint, the previous extension is overwritten with the new one.

@Martijn-ATO
Copy link
Author

Oh, I'm using the XML backend version, not the SQL version.

@phax
Copy link
Owner

phax commented Jun 27, 2018

Thanks for the inforation - sorry for that. Bad testing on my side :(

@phax phax reopened this Jun 27, 2018
phax added a commit that referenced this issue Jun 27, 2018
@phax
Copy link
Owner

phax commented Jun 27, 2018

But now :)

@phax phax closed this as completed Jun 27, 2018
@Martijn-ATO
Copy link
Author

Yay, the textarea is now populated with the existing extension content, however, I'm afraid it is becoming more complicated. The system doesn't accept an XML fragment. Since we would like to adhere to the OASIS specification, the Extension element consists of several child elements. At the moment I can add one XML element but not multiple.
This works

<Wrapper>
   <One>1</One>
   <Two>2</Two>
</Wrapper>

And turns into

   <bdxr:Extension>
      <Wrapper>
         <One>1</One>
         <Two>2</Two>
         </Wrapper>
   </bdxr:Extension>
</bdxr:Endpoint>

But entering this

<One>1</One>
<Two>2</Two>

in the textarea results in an error:
Optional extension to the endpoint. If present it must be valid XML content! The extension must be XML content.

Kind regards,
Martijn.

@phax phax reopened this Jun 28, 2018
@phax
Copy link
Owner

phax commented Jul 12, 2018

Here I'm having a slight problem. I have no real way to determine, if this is done by purpose or not.
I suggest we stick to the current solution of having exactly one XML extension, and as soon as PEPPOL switches to the OASIS BDXR scheme, I can drop a lot of legacy and will also improve the extensions.
Does that sound okay for you for now?
If that is feasable, I will create an issue and refer to this one.

@phax phax closed this as completed Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants