Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode may be active even when color_mode option is disabled #527

Closed
cblavier opened this issue Dec 6, 2024 · 0 comments · Fixed by #528
Closed

Dark mode may be active even when color_mode option is disabled #527

cblavier opened this issue Dec 6, 2024 · 0 comments · Fixed by #528
Assignees
@cblavier
Labels
bug Something isn't working

Comments

@cblavier
Copy link
Contributor

cblavier commented Dec 6, 2024

If psb_selected_color_mode is present in the browser's local storage (because you browsed to another color_mode enabled storybook or because your storybook previously had color_mode enabled) then dark mode may be enabled, even if your storybook has color_mode: false option
@cblavier cblavier added the bug Something isn't working label Dec 6, 2024
@cblavier cblavier self-assigned this Dec 6, 2024
@cblavier cblavier linked a pull request Dec 6, 2024 that will close this issue
color_mode hook is now checking if color_mode option is enabled #528
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cblavier cblavier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

color_mode hook is now checking if color_mode option is enabled phenixdigital/phoenix_storybook
1 participant
@cblavier