Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add organ system validator and validation examples #127

Merged
merged 22 commits into from
Nov 12, 2022

Conversation

ielis
Copy link
Collaborator

@ielis ielis commented Nov 3, 2022

Add examples to demonstrate validation functionality.

We will add three phenopackets: one with syntax errors, the other with semantic errors, and the last with no errors.

ielis added 3 commits November 3, 2022 18:27
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
@ielis ielis changed the base branch from main to develop November 3, 2022 22:31
ielis added 19 commits November 8, 2022 11:58
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
…ation error. Absence of a `oneof` field in `Variation` leads to an error.

Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
Signed-off-by: Daniel Danis <daniel.gordon.danis@protonmail.com>
@ielis ielis marked this pull request as ready for review November 12, 2022 04:16
@ielis ielis changed the title Add validation examples Add organ system validator and validation examples Nov 12, 2022
@ielis ielis merged commit 8969521 into phenopackets:develop Nov 12, 2022
@ielis ielis deleted the add_validation_examples branch November 12, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant