Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing Create Patient button on my_patients page #303

Closed
logust79 opened this issue Dec 18, 2020 · 13 comments
Closed

missing Create Patient button on my_patients page #303

logust79 opened this issue Dec 18, 2020 · 13 comments
Assignees
Labels

Comments

@logust79
Copy link
Contributor

Would be good to have a button or link to the create_patient page on the my_patients page.

@pontikos
Copy link
Contributor

pontikos commented Dec 18, 2020 via email

@YuanTian1991
Copy link
Contributor

I think only Admin can create user? That's why I specifically did not put button in my_patient page. The only way to create user is in manage_patient page, which is Admin only.

In my idea, my_patient page is used to show all accessible patient (only to view). Also, I want to have 3 other pages for gene, hpo, variants.

@pontikos
Copy link
Contributor

pontikos commented Dec 18, 2020 via email

@YuanTian1991
Copy link
Contributor

OK, I will add a button, only visible for Admin user.

@pontikos
Copy link
Contributor

I also think it should be possibel to upload files and delete patients from that page using the edit button.
I don't like to have to go to another part of the website to manage patients.

@pontikos
Copy link
Contributor

@YuanTian1991 can you implement this please and close issue?

@pontikos pontikos added this to the slick_frontend milestone May 18, 2021
@pontikos
Copy link
Contributor

@alanwilter @YuanTian1991 I understand there has been some issues fixing this that you have discussed on Slack. Can you please provide a succint update here on what the issues are so we are all on the same page?

@alanwilter
Copy link
Collaborator

alanwilter commented May 25, 2021

I need to sort #352 and #169 first for @YuanTian1991. I'm working on genes now.

@alanwilter
Copy link
Collaborator

alanwilter commented May 26, 2021

To summarise:

  1. Create a delete_user endpoint;
  2. Create an endpoint to return all Genes for a given user;
  3. Create an endpoint to return all HPOs for a given user;
  4. Create an endpoint to return all Variants for a given user.

However, I need to check which conflicts these actions may have with refactoring of the code for migrating to new schema. I won't invest time creating endpoints that may still use the old schema.

@pontikos
Copy link
Contributor

see #242

@pontikos
Copy link
Contributor

@YuanTian1991 for demo you need to handle 405 {"error":"Demo user not authorised"} message

@YuanTian1991
Copy link
Contributor

Fixed this bug.

@alanwilter
Copy link
Collaborator

Should we close it then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants