Able to use either local or S3 remote vcf file #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for phenopolis-dev canceled. 🔨 Explore the source changes: 1642f73 🔍 Inspect the deploy log: https://app.netlify.com/sites/phenopolis-dev/deploys/618a5398e310b700088789f0 |
IsmailM
approved these changes
Nov 9, 2021
IsmailM
reviewed
Nov 9, 2021
public.env
Outdated
| @@ -6,7 +6,7 @@ PH_DB_USER=phenopolis_api | |||
| PH_DB_PASSWORD=phenopolis_api | |||
| PH_DB_PORT=5432 | |||
|
|
|||
| S3_VCF_FILE_URL="s3://phenopolis-vcf/August2019/merged2.vcf.gz" | |||
| S3_VCF_FILE_URL="schema/small_demo.vcf.gz" | |||
There was a problem hiding this comment.
IMO - we should rename this environment variable so that it is not specific to S3
(And then add a comment in the Readme etc. that this variable can be an S3 link (provided Secret key etc. variables are provided)
There was a problem hiding this comment.
Good point. I'll do this and then merge.
There was a problem hiding this comment.
If you do change the variable - let me know before you merge - so that I can add this variable to the AWS EB environment...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Considering Merge **
Essentially I simplified and made the setup around S3_VCF_FILE_URL more flexible.
I've updated
cyvcf2to version 0.30.12.There's no critical changes here.