Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix case sensitiveness on autocomplete endpoint #67

Merged
merged 2 commits into from
Jul 5, 2020
Merged

fix case sensitiveness on autocomplete endpoint #67

merged 2 commits into from
Jul 5, 2020

Conversation

priesgo
Copy link
Contributor

@priesgo priesgo commented Jul 5, 2020 •
edited
Loading

This deals with the case sensitiveness of search (AKA autocomplete) endpoint.

  • Searching by gene symbols is now case insensitive (eg: BRCA2, brca2, bRCa2 will give the same results)
  • The resulting gene is displayed with the original gene symbol not the upper cased version (eg: C16orf80 is displayed when searched by C16ORF80)
  • Gene search also looks at synonyms now (eg: BRCC2 returns BRCA2)
  • Patient search is also case insensitive now (eg: ph0000018 and PH0000018 are the same)
  • Phenotype search is also case insensitive. Phenotype names are stored in plain language mixing upper and lower case, thus before abnormality will match only phenotypes having abnormality but not Abnormality. This is now fixed.

#66

@priesgo priesgo linked an issue Jul 5, 2020 that may be closed by this pull request
Gene search: search is case sensitive and only supports upper case #66
Closed
@pontikos pontikos merged commit a32ab12 into dev-live Jul 5, 2020
@pontikos pontikos deleted the 66-autocomplete-case-insensitive branch July 5, 2020 23:23
pontikos added a commit that referenced this pull request Jul 5, 2020
@pontikos @alanwilter
@priesgo @IsmailM
Dev live (#68)
6e69cb5 
* Reoganised and pylinted

* corrects handling of gene synonyms and upper/lower case (#55)

* Docker dev mode (#57)

* Pylint format

* Pylint format

* Docker file for dev-mode container

* Typo

* Using pysam 0.15.4 and gunicorn

* Deleted dev_env.sh, never needed

* Updated README for docker usage

* added SQL schema as separate file

Co-authored-by: pontikos <n.pontikos@gmail.com>

* Add demo Postgres db (#59)

Add demo_database.sql with demo data (from original demo sql)

* remove unused commented code

* Use `os.getenv` instead of `os.environ` so that an default value for environmental variables can be sent

* fix case sensitiveness on autocomplete endpoint (#67)

* fix case sensitiveness on autocomplete endpoint

* gene search includes gene synonyms

Co-authored-by: Alan Silva <alanwilter@gmail.com>
Co-authored-by: Pablo Riesgo Ferreiro <priesgoferreiro@gmail.com>
Co-authored-by: Ismail Moghul <ismail.moghul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pontikos pontikos pontikos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gene search: search is case sensitive and only supports upper case
2 participants
@priesgo @pontikos