-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport deprecation changes for Bootstrap 2 #1158
base: v2.3.x
Are you sure you want to change the base?
Conversation
Hi, I would love to see movement on this one! |
My plan was to add more tests, but I don't have much time now (I've already added some). Anyway I'm using my fork in a Symfony 2.7 project + Bootstrap 2, so I would like to have a feedback on this PR |
sorry did not see this at all :( does the testsuite run with symfony3 ? i remember there were some issues. |
Now it's passing, but I haven't ported all the tests form master, some were not compatible. |
What's left to do here? Would love to start using this on 2.x |
can we review this thogether: https://travis-ci.org/phiamo/MopaBootstrapBundle/builds/136118152 |
I can't seem to find @carlo1138 branch to make changes. I've had to checkout the actual commit. All of the config yml files should wrap parameters with quotes. From 4.0 exceptions will be thrown. Also, if you actually run this version, it fails. The extensions are wrong: mopa.form.help_extension:
class: Mopa\Bundle\BootstrapBundle\Form\Extension\HelpFormTypeExtension
arguments:
- { tooltip_icon: %mopa_bootstrap.form.tooltip.icon%, tooltip_placement: %mopa_bootstrap.form.tooltip.placement% }
tags:
- { name: form.type_extension, alias: form } Should be
Also, some Types haven't been updated. e.g. TabType still has "public function setDefaultOptions(OptionsResolverInterface $resolver)" |
Do we need to support 4.0? 😄
In which version?
Yep, if we want both 2.x and 3.x support, we need to use both methods, like it was suggested in #1115 (comment) Now I've rebased my branch with a new travis.yml, it's not the same as your v2.3.x, but similar |
LOL, I had already done both of them, I've just forgot about it, see f6a4a12. There is a BC layer to support all the symfony versions. |
Form aliases are deprecated and will be removed in 3.0. You must use the Fully Qualified Class Names instead of form aliases now. |
Done @phiamo |
@carlo1138 what is the status here? |
Similar to #1115 but with support for Symfony 2.3
What do you think?