New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fontawesome4 less and some imperfection of #1119 #1212

Open

ttskch wants to merge 2 commits into phiamo:master from ttskch:fix-fontawesome4-less

+35 −33

Contributor

ttskch commented Mar 6, 2017

Already merged PR #1119 is not perfect in following points.

In font-awesome4 directory, spinning.less is deleted but font-awesome.less still depends on spinning.less.
In font-awesome directory, font-awesome.less no longer depends on spinning.less but spinning.less file still exists.

This PR fixes these. Thanks.

Takashi Kanemoto added 2 commits

March 6, 2017 10:46


          Remove unnecessary file, spinning.less, from fontawesome

640b6f5


          Copy animated.less from fontawesome to fontawesome4 and import it ins…

a4339f4

…tead of non-existent spinning.less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment