Skip to content

Commit

Permalink
Make it clearer to the user that they haven't overridden onLogin/Regi…
Browse files Browse the repository at this point in the history
…ster (matrix-org#7237)
  • Loading branch information
anoadragon453 authored and phil-flex committed Jun 16, 2020
1 parent c032017 commit 800d7df
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
1 change: 1 addition & 0 deletions changelog.d/7237.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Change log line that told user to implement onLogin/onRegister fallback js functions to a warning, instead of an info, so it's more visible.
3 changes: 1 addition & 2 deletions synapse/static/client/login/js/login.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,7 @@ matrixLogin.password_login = function() {

matrixLogin.onLogin = function(response) {
// clobber this function
console.log("onLogin - This function should be replaced to proceed.");
console.log(response);
console.warn("onLogin - This function should be replaced to proceed.");
};

var parseQsFromUrl = function(query) {
Expand Down
2 changes: 1 addition & 1 deletion synapse/static/client/register/js/register.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,5 @@ matrixRegistration.signUp = function() {

matrixRegistration.onRegistered = function(hs_url, user_id, access_token) {
// clobber this function
console.log("onRegistered - This function should be replaced to proceed.");
console.warn("onRegistered - This function should be replaced to proceed.");
};

0 comments on commit 800d7df

Please sign in to comment.