Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1063: Begin 0.11 porting process #1187

Closed

Conversation

kennystrawnmusic
Copy link
Contributor

@kennystrawnmusic kennystrawnmusic commented Jan 26, 2023

Version 0.11 of the bootloader crate introduces a lot of breaking changes, so time to start work on making sure that all posts are up-to-date to (hopefully) make it far easier for Phil to move forward with fixing #1063.

@kennystrawnmusic
Copy link
Contributor Author

Decided to also fix all the broken links throughout all editions as part of this pull request, as a kind of thank-you-in-advance for merging.

@phil-opp phil-opp mentioned this pull request Jan 26, 2023
Copy link
Owner

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I left some comments, otherwise this looks good.

The broken link fixes are already useful for the current edition, so I pulled them out into a separate PR in #1188.

blog/content/edition-3/posts/02-booting/index.md Outdated Show resolved Hide resolved
Comment on lines 455 to 459
bootloader-x86_64-bios-boot-sector = "0.11.0"
bootloader-x86_64-bios-common = "0.11.0"
bootloader-x86_64-bios-stage-2 = "0.11.0"
bootloader-x86_64-bios-stage-3 = "0.11.0"
bootloader-x86_64-bios-stage-4 = "0.11.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not need to depend on these sub crates.

}
}
[dependencies]
bootloader-x86_64-uefi = "0.11.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This dependency should not be needed.

@kennystrawnmusic
Copy link
Contributor Author

Alright, trimming down the excess when I get home later — first day on a new job, so will be much busier today than I was yesterday. Expect a fix around 10PM Pacific time.

@phil-opp
Copy link
Owner

Thanks! There's no need to hurry, good luck with the new job!

@kennystrawnmusic
Copy link
Contributor Author

Alright, just submitted a new commit that fixes the issues brought up in the line comments.

@kennystrawnmusic
Copy link
Contributor Author

Fixed some more links that died along the way too

@hecatia-elegua
Copy link
Contributor

Uhm, for me https://web.archive.org/web/20190217233448/https://www.flingos.co.uk/docs/reference/Global-Descriptor-Table/ still works. Maybe we could include both links somehow

phil-opp added a commit that referenced this pull request Mar 25, 2023
@phil-opp
Copy link
Owner

Uhm, for me https://web.archive.org/web/20190217233448/https://www.flingos.co.uk/docs/reference/Global-Descriptor-Table/ still works. Maybe we could include both links somehow

Yeah, I think the links fixed in 7b2efae were only temporary failures, so I think we can keep the original links.

Alright, just submitted a new commit that fixes the issues brought up in the line comments.

Thanks, looks good to me now! Sorry for the long delay.

I just merged the changes related to the third edition into the edition-3 branch in commit 79be18b. The link fixes were already merged into main in #1188.

@phil-opp phil-opp closed this Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants