Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t for 'open in new tab' does not respect Firefox new tab location preferences #2670

Closed
vaibhavsagar opened this issue Sep 26, 2017 · 7 comments

Comments

@vaibhavsagar
Copy link

I have browser.tabs.insertRelatedAfterCurrent set to false in about:config but Vimium does not respect this preference when opening a new tab and opens it after the current one instead.

@mrmr1993
Copy link
Contributor

We can't read preferences from about:config (here for some vaguely-related discussion), and our behaviour was set up to mirror Chrome's default, which is non-configurable.

I don't get to make these decisions, but I can't imagine this is high-value enough to warrant its own option in our settings.

@vaibhavsagar
Copy link
Author

It's high-value for me 😃. Would you be open to a PR? I think it might fit in 'Advanced Options'.

@reinerh
Copy link

reinerh commented Nov 29, 2017

That behaviour is also slightly annoying to me. I'm used to creating new tabs at the end of the list, which is currently unfortunately not possible with vimium.
I would also appreciate an advanced setting for this (or a new command that creates tabs at the end).

@benhartley
Copy link

Firefox is not behaving in the same way as Chromium for me. In Chromium, new tabs are opened in context groups, but the newest tab in the group is opened in the furthest right position. In Firefox, the new tab is always opened in the position immediately to the right of the current tab.

This is sub-optimal, since when opening several tabs from one page, a likely use case is to then review those tabs in the order they were opened (left to right), giving the benefit that the next oldest opened link will most likely have already loaded by the time you navigate to it, and so on as you move right through the tabs.

I'd be happy enough if Firefox behaved the same way as Chromium here so tabs were opened in the furthest right position within a context group. Failing that it does seem like something that should be configurable.

@CyanBlob
Copy link

CyanBlob commented Mar 5, 2018

I'd like to add that how Vimium opens new tabs on Firefox can be a huge pain when using TreeStyleTabs, which is a popular Firefox addon. Right now, every new tab is opened as a child of the current tab, which causes some annoyingly deep trees. I would prefer for createTab to create the new tab at the root of the tree, not as a child of the current tab

@PhilippWendler
Copy link

I agree, but I would like to add that Vomnibar.activateEditUrlInNewTab should still open tabs next to the current tab, because such a new tab will be related to the current tab. Only Vomnibar.activateInNewTab should open a new tab at the end of the tab bar.

@philc
Copy link
Owner

philc commented Jan 10, 2020

This is partially addressed with a new option to the createTab command in #2895, and will go out with the next Vimium version.

@philc philc closed this as completed Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants