Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not specify tab.index for new tab. #2863

Closed
wants to merge 1 commit into from
Closed

Do not specify tab.index for new tab. #2863

wants to merge 1 commit into from

Conversation

ris58h
Copy link
Contributor

@ris58h ris58h commented Dec 12, 2017

Seems like it's a fast fix for #2670.

@smblott-github
Copy link
Collaborator

Thanks, @ris58h. However, this fix applies to everywhere that openUrlInNewTab is used. Perhaps we need to be more selective. For example, when called from visual mode, the status quo behaviour seems best. We'd have to look at the other cases one by one.

@philc
Copy link
Owner

philc commented Jan 10, 2020

This is addressed as best we can with a new option to the createTab command in #2895, and will go out with the next Vimium version.

@philc philc closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ris58h @smblott-github @philc