Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank doesn't work in firefox 57.0 #2833

Open
danielbaniel opened this issue Nov 22, 2017 · 27 comments
Open

Yank doesn't work in firefox 57.0 #2833

danielbaniel opened this issue Nov 22, 2017 · 27 comments

Comments

@danielbaniel
Copy link

danielbaniel commented Nov 22, 2017

When I yank I see the vimium tooltip at the bottom - "yanked ..."

However I get nothing on my clipboard.

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:57.0) Gecko/20100101 Firefox/57.0
Vimium: 1.61.1

@ghost
Copy link

ghost commented Nov 23, 2017

Same here on GNU/Linux version.

@itachi-19
Copy link

itachi-19 commented Nov 23, 2017

Same here.. Firefox Quantum on linux :/

@azdanov
Copy link

azdanov commented Nov 28, 2017

Same here.
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0
Vimium: 1.61.1

@smblott-github
Copy link
Collaborator

Yank is broken on FF; a fix was merged on Saturday and will be released soon.

@vcunat
Copy link

vcunat commented Jan 2, 2018

Close?

@vcunat
Copy link

vcunat commented Jan 2, 2018

Hmm, actually I currently experience problems on FF with the yy command :-/
EDIT: Now it works on FF for me... I'm not sure what was wrong.

@smblott-github smblott-github reopened this Jan 2, 2018
@ghost
Copy link

ghost commented Jan 6, 2018

It's also not working with Vivaldi 1.14.1036.3 + X11 (1.19.6-2) + Linux (4.14.10-1-ARCH). Similar behavior: the plugin appears to work, reports it's yanked, but does not change any of the X clipboards (primary, secondary, or clipboard).

@neilhwatson
Copy link

Seems to be with certain sites. For example I can't yank a specific tweet from twitter. I'm using FF 59.0.2 on Linux

@matt-snider
Copy link

Also having this issue in FF 63.0.3 -- reports the text has been yanked, but isn't saved to the clipboard. Did anyone find a cause or fix for this?

@vcunat
Copy link

vcunat commented Dec 9, 2018

For me it's still flaky – sometimes it gets into the clipboard and sometimes doesn't; it's quite annoying for my habits. I haven't dug into causes; I've got basically no JS/... knowledge.

@circld
Copy link

circld commented Feb 11, 2019

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0
Vimium: 1.64.3

Issue

  • yanking the URL fails
  • the notification at the bottom of the page suggests that it succeeded (this is the real pain point, bc you think it succeeded and don't realize it has failed until you end up googling some bit of text on your clipboard 😢 )
  • failure is inconsistent

Example

here's a concrete case where vimium fails to yank the URL (yy):

  1. navigate to https://issues.apache.org/jira/projects/KAFKA/issues
  2. click on any ticket that isn't the "default" (i.e., the one in the URL)
  3. yy
  4. check whether the yanked URL matches the ticket you previously clicked on (in my case, it does not)
  5. now click on the ticket link above the title to open the ticket itself. for instance:
    image
  6. when the ticket opens, yy once more (in my case, it does not)
  7. click anywhere within the page and try again; now it should yank the URL correctly

i've noticed that this behavior seems to be consistent across JIRA ticketing systems. in some cases, it seems like it may be a focus problem (e.g., step 7 "fixes" the issue).

also, no idea if this is related, but yanking using link hints has also failed for me (e.g., a link in a comment on a github PR diff comment).

@magras
Copy link

magras commented Feb 17, 2019

I had even more bizarre behavior: after yanking current url (yy) and trying to open it in a new tab (P), I've got google page. Probably google came from empty default search engine. Then I waited for a few seconds and opened new tab again (P). I've got wrong url described by @circld in step 4.

@vcunat
Copy link

vcunat commented Feb 18, 2019

What I noticed is that when I yy, firefox won't react to P until the "yanked" notification label disappears.

@innaterebel
Copy link

@magras What browser are you using? I start experiencing exactly what you describe in the latest Dev version of Chrome, I thought it was some regression on Chrome's nightly side.

@vcunat
Copy link

vcunat commented Feb 18, 2019

Well, this thread is supposedly about Firefox.

@innaterebel
Copy link

Yes, so it surprised me a supposed Firefox user was describing exactly what I am seeing on Chrome, it may indicate Chrome is changing its clipboard API to match that of Firefox.

@magras
Copy link

magras commented Feb 19, 2019

@innaterebel, I'm using Fireforx 65.0.1 (64-bit) on different OS'es. I can reproduce behaviour described earlier only with link provided by @circld.

Also I can add to this observation that firefox will ignore all vimium keybindings, not only P. If I mouse click on a page to bring focus back while notification visible, I can P immediately.

@philc
Copy link
Owner

philc commented May 12, 2019

Thanks folks for the discussion! This is fixed in #3260, which has been released to the chrome store.

@philc philc closed this as completed May 12, 2019
@philc
Copy link
Owner

philc commented May 21, 2019

This went out in v1.64.6 which is live on the Firefox store as of right now.

@waldauf
Copy link

waldauf commented Jul 12, 2019

For me is yank still broken - sometimes works and sometimes never.

Vimium: 1.64.6
FF: 67.0.4
OS: Archlinux

@daraul
Copy link

daraul commented Dec 29, 2019

I'm having this problem as well. Sometimes it'll work, sometimes it won't.

Vimium: 1.64.6
FF: 71.0
OS: Archlinux

@gdh1995
Copy link
Contributor

gdh1995 commented Feb 14, 2020

@philc @Mendess2526 #2521 (comment) (and #2677 (comment)) has just reported the same issue, so I think PR #3277 might not fix the problem on Firefox. Then We may reopen this issue.

I may get some rest time to test it in this weekend.

@j-cr
Copy link

j-cr commented Oct 26, 2020

Vimium 1.66, ff 68, yy doesn't work normally; it DOES work however if you click on the page and THEN press yy.

@xp-vit
Copy link

xp-vit commented Jan 23, 2023

Vimium 1.67.4 and FF 109.0 (64-bit) yanking doesn't work for me.

Frankly speaking it doesn't work for already some time, but I just decided to report it. When I press "yy" browser shows that link was "Yanked", however nothing appears in clipboard.

Is it some FF security limitation, or we have chances to fix it?

P.S.: Thanks for great plugin!!

@vcunat
Copy link

vcunat commented Jan 23, 2023

You should update, such a problem was solved relatively recently. Auto-update gave me 1.67.6 and it works for me there again.

@xp-vit
Copy link

xp-vit commented Jan 25, 2023

Is there an update available? My FF needs to provide me with any updates for my 1.67.4.

@anmolmathias
Copy link

i'm still experiencing this problem :\

ver 1.99.997. firefox. ubuntu 24.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests