Add option to enable Javascript URLs #3209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may send the URL to content scripts and then vimium_frontend injects a |
That sounds better. |
smblott-github
added a commit
to smblott-github/vimium
that referenced
this pull request
Dec 27, 2018
Since `chrome.tabs.update()` no longer supports `javascript:` URLs, here we inject them into the page itself. Replaces philc#3167. Replaces philc#3209. Fixes philc#3178.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea for resolving #3178 (and includes #3167).
chrome.tabs.updatecan no longer be used to open Javascript URLs (hence Javascript bookmarks not working anymore #3178).chrome.tabs.executeScriptwhen encountering javascript bookmarks #3167 fixes this by usingchrome.tabs.executeScriptinstead.chrome.tabs.executeScriptwhen encountering javascript bookmarks #3167 the Javascript now executes in Vimium's context, hence with Vimium's elevated permissions. To enable Usechrome.tabs.executeScriptwhen encountering javascript bookmarks #3167 behind users' backs would be irresponsible.So this PR proposes:
chrome.tabs.executeScriptwhen encountering javascript bookmarks #3167 as is, however...The option looks like this:
The default (which everybody will inherit) is
false.Fixes #3178.
Fixes #3167.