FindMode: clear focus of HUD iframe on exit #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philc
requested changes
Jan 5, 2020
gdh1995
force-pushed
the
blur-hud-on-firefox
branch
from
505aa08 to
e99f58f
Compare
gdh1995
force-pushed
the
blur-hud-on-firefox
branch
from
e369c84 to
a8e3a25
Compare
philc
reviewed
Jan 6, 2020
in fact, the old `unfocusIfFocused` has been broken for a while, since hud iframe is inside a shadowRoot on Firefox 63+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Firefox, if an
<iframe>disappears when it's focused, then it will keep focused. This feature has caused the 2nd problem in #3245 .This PR should fix #3245 , and it works well on my Firefox 69 (stable x64) + Win 10.
As for Firefox 67, there's still some incorrect results about colors of selection text after FindMode has exited, but I think it's because of inner bugs of Firefox - this PR works well enough on Firefox 69...