Vomnibar: fix a bug preventing ctrl-enter from working #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome may assign `"\n"` as the `key` property of an `Enter` key, which made `Ctrl+Enter` not work as expected.
|
I didn't test this on Windows, but it doesn't break OSX. Thanks @gdh1995 |
|
Added: Here's my test on Chrome 98 and Win11:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome may assign
"\n"as thekeyproperty of anEnterkey,which made
Ctrl+Enternot work as expected.This helps commit 2268e49 (see #2914) work well on Windows, and may help #3880