Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all golangci-lint warnings #82

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Fix all golangci-lint warnings #82

merged 2 commits into from
Jun 2, 2024

Conversation

erikdubbelboer
Copy link
Contributor

No description provided.

philippgille
philippgille reviewed May 20, 2024
View reviewed changes
Copy link
Owner

@philippgille philippgille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative, thanks!

We should probably add a linting step to CI as well. I can create a follow-up PR for that after this one is merged.

collection_test.go Outdated Show resolved Hide resolved
db_test.go Outdated Show resolved Hide resolved
db_test.go Outdated Show resolved Hide resolved
vector.go Show resolved Hide resolved
@erikdubbelboer
Copy link
Contributor Author

I fixed all suggestions.

philippgille
philippgille approved these changes Jun 2, 2024
View reviewed changes
Copy link
Owner

@philippgille philippgille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@philippgille philippgille merged commit 34ba879 into philippgille:main Jun 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippgille philippgille philippgille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikdubbelboer @philippgille