Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook Logging #1369

Closed
wants to merge 26 commits into from
Closed

Webhook Logging #1369

wants to merge 26 commits into from

Conversation

mcaulifn
Copy link
Contributor

@mcaulifn mcaulifn commented Nov 2, 2021 •
edited
Loading

  • Move metadata to JSON object for more structured logging
  • Add additional detail to logs
  • Use supportedEvents list to quickly exit if not supported
  • Making handle function definition consistent with other functions in lambda

@mcaulifn mcaulifn marked this pull request as draft November 2, 2021 20:10
@mcaulifn mcaulifn changed the title Mcaulifn/webhook logging 2 Webhook Logging Nov 3, 2021
@mcaulifn
Copy link
Contributor Author

mcaulifn commented Nov 3, 2021

Keeping this draft until #1228 is merged

@mcaulifn mcaulifn marked this pull request as ready for review November 8, 2021 13:05
@npalm npalm self-requested a review November 9, 2021 08:20
mcaulifn and others added 24 commits November 9, 2021 10:35
@mcaulifn
fix(logging): Add context to webhook logs
75fa8f3 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn
Adding property
a4cf374 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn
Adding property
e34dc9a 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn
Reverting payload name change
4718103 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn
Adding note
343b6b9 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn
feat: add option to format logging in JSON for lambdas (philips-labs#…
b074b71 
…1228)

* feat(log): Adding Support for JSON logging

* Passing in log_type to other lambdas

* Casting e as Error

* Add log_level variable, fix formatting

* Correcting failed resolution

* Using latest releases for testing

* Passing in log_level to sub-modules

* Update terraform.yml

* Manually removing `node-fetch`

* Moving logger object to new file

* Resolving merge from develop
Wouldn't be a conflict resolve without a miss

* Logging when job is not queued

* Updating handler names

Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@toast-gear @mcaulifn
fix: reducing verbosity of role and profile (philips-labs#1358)
8d7b9b9 
Co-authored-by: Callum <callum@domain.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@marekaf @mcaulifn
feat: add option to specify SSE config for dist bucket (philips-labs#…
b7f0711 
…1324)

* feat: dist bucket SSE config

* fixup! feat: dist bucket SSE config

Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@JeroenKnoops @mcaulifn
chore(ci): Add provenance file (philips-labs#1371)
a8e050c 
Add provenance file for releases.

SLSA level 1

Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn
Change logFields to object
2bbf395 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@npalm @mcaulifn
fix: configurable metadata options for runners (philips-labs#1377)
37fb3d1 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump nock in /modules/runners/lambdas/runners (philips-labs#1387)
3b3f96b 
Bumps [nock](https://github.com/nock/nock) from 13.1.4 to 13.2.0.
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md)
- [Commits](nock/nock@v13.1.4...v13.2.0)

---
updated-dependencies:
- dependency-name: nock
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump aws-sdk (philips-labs#1388)
d615da4 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1019.0 to 2.1023.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1019.0...v2.1023.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump nock in /modules/webhook/lambdas/webhook (philips-labs#1391)
217855e 
Bumps [nock](https://github.com/nock/nock) from 13.1.4 to 13.2.0.
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md)
- [Commits](nock/nock@v13.1.4...v13.2.0)

---
updated-dependencies:
- dependency-name: nock
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump @aws-sdk/client-ssm in /modules/runners/lambdas/runners (p…
dd56286 
…hilips-labs#1393)

Bumps [@aws-sdk/client-ssm](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-ssm) from 3.39.0 to 3.40.0.
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-ssm/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.40.0/clients/client-ssm)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-ssm"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump aws-sdk in /modules/webhook/lambdas/webhook (philips-labs…
60bf425 
…#1395)

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1019.0 to 2.1024.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1019.0...v2.1024.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump philips-labs/slsa-provenance-action from 0.2.0 to 0.2.2 (p…
a7fbe2f 
…hilips-labs#1386)

Bumps [philips-labs/slsa-provenance-action](https://github.com/philips-labs/slsa-provenance-action) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/philips-labs/slsa-provenance-action/releases)
- [Changelog](https://github.com/philips-labs/slsa-provenance-action/blob/main/.goreleaser.yml)
- [Commits](philips-labs/slsa-provenance-action@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: philips-labs/slsa-provenance-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump @aws-sdk/client-ssm in /modules/webhook/lambdas/webhook (p…
86663b7 
…hilips-labs#1394)

Bumps [@aws-sdk/client-ssm](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-ssm) from 3.39.0 to 3.40.0.
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-ssm/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.40.0/clients/client-ssm)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-ssm"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@npalm @mcaulifn
fix: update return codes, no error code for job that are ignored (phi…
6051676 
…lips-labs#1381)

Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump aws-sdk in /modules/runners/lambdas/runners (philips-labs…
9b86569 
…#1396)

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1019.0 to 2.1024.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1019.0...v2.1024.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@dependabot @mcaulifn
chore: Bump aws-lambda in /modules/webhook/lambdas/webhook (philips-l…
09eee20 
…abs#1392)

Bumps [aws-lambda](https://github.com/awspilot/cli-lambda-deploy) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/awspilot/cli-lambda-deploy/releases)
- [Changelog](https://github.com/awspilot/cli-lambda-deploy/blob/master/ChangeLog)
- [Commits](awspilot/cli-lambda-deploy@v1.0.6...v1.0.7)

---
updated-dependencies:
- dependency-name: aws-lambda
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@toast-gear @mcaulifn
feat: support single line for app private key (philips-labs#1368)
fa88fc9 
* feat: support single line private keys

* docs: docs for the new key storage options

* docs: use original doc style

* style: use single quotes

* chore: fmt ts files

* docs: use original language more

* docs: use the original language more

* fix: use correct char code for new line

Co-authored-by: Callum <callum@domain.com>
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@npalm @mcaulifn
chore(runners): Add unit test for line break in app key (philips-labs…
c7dc0b2 
…#1341) (philips-labs#1397)

Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@giautm @mcaulifn
chore(docs): remove broken links (philips-labs#1385)
0dd7321 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn mcaulifn force-pushed the mcaulifn/webhook-logging-2 branch from 9bc7f0a to 0dd7321 Compare November 9, 2021 15:42
@mcaulifn
Merge branch 'develop' into mcaulifn/webhook-logging-2
e903715
@mcaulifn
reverting status change
279a6de 
Signed-off-by: Nathaniel McAuliffe <nmcauliffe@expediagroup.com>
@mcaulifn mcaulifn mentioned this pull request Nov 9, 2021
Merged
@mcaulifn
Copy link
Contributor Author

mcaulifn commented Nov 9, 2021

Closing in favor of #1401

@mcaulifn mcaulifn closed this Nov 9, 2021
@mcaulifn mcaulifn deleted the mcaulifn/webhook-logging-2 branch November 9, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm Awaiting requested review from npalm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcaulifn @toast-gear @marekaf @JeroenKnoops @npalm @giautm