Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block name should default to dev/xvda #2018

Closed
wants to merge 1 commit into from
Closed

fix: block name should default to dev/xvda #2018

wants to merge 1 commit into from

Conversation

gusfune
Copy link
Contributor

@gusfune gusfune commented May 5, 2022

This fixes the issue reported on #2017.

@npalm
Copy link
Member

npalm commented May 5, 2022

close #2017

Copy link
Member

@ScottGuymer ScottGuymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice catch

@npalm
Copy link
Member

npalm commented May 5, 2022

Defaults in variables files are available in 2 files. One in the root and one per module, this to let users use the module per module or as whole. To provide a quick release I have opend a PR on top of this #2019 with the fixed. @gusfune thanks for you fast response and quick fix. We value your contribution!

@npalm
Copy link
Member

npalm commented May 6, 2022

closing in fovour of #2019

@npalm npalm closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants