Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): Support multiple arrays of tags is matchers. #2736

Merged
merged 11 commits into from
Dec 13, 2022

Conversation

npalm
Copy link
Member

@npalm npalm commented Dec 8, 2022

Refactored the matcher to support multiple arrays of tags. This allow to match multiple set of tags on a single runner configuration. Useful to match for example [self-hosted, ubuntu-latest] and [self-hosted, ubuntu-2204] on the same runner.

@npalm npalm changed the base branch from develop to next December 8, 2022 19:24
@npalm npalm changed the title feat: Support multiple arrays of tags is matchers. feat(webhook): Support multiple arrays of tags is matchers. Dec 8, 2022
@npalm
Copy link
Member Author

npalm commented Dec 9, 2022

close #2715

@npalm npalm requested a review from ScottGuymer December 11, 2022 22:20
@GuptaNavdeep1983
Copy link
Contributor

@npalm, not sure if this PR gives an error on applying without commit 2ab5f46#diff-69a0e0ca008de526fb8fe2c1d1995d6632c16a9cd1bc58c9f58eec9ce1676f30!

@npalm
Copy link
Member Author

npalm commented Dec 12, 2022

Tested the branch with the example for multi-runners, all works fine.

@npalm npalm self-assigned this Dec 12, 2022
@GuptaNavdeep1983 GuptaNavdeep1983 self-requested a review December 13, 2022 08:39
@npalm npalm merged commit 087c728 into next Dec 13, 2022
@npalm npalm deleted the feat/support-multiple-matchesrs branch December 13, 2022 09:41
npalm added a commit that referenced this pull request Dec 13, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers

* Run ci for webhook

* fix terraform type

* fix formatting

* fix terraform type

* fix terraform type

* fix: some fixes.

* fix: readme.

* fix example workflow labes

* add test for multiple label match

* add test for multiple label match

Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm added a commit that referenced this pull request Dec 13, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers

* Run ci for webhook

* fix terraform type

* fix formatting

* fix terraform type

* fix terraform type

* fix: some fixes.

* fix: readme.

* fix example workflow labes

* add test for multiple label match

* add test for multiple label match

Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm added a commit that referenced this pull request Dec 28, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers

* Run ci for webhook

* fix terraform type

* fix formatting

* fix terraform type

* fix terraform type

* fix: some fixes.

* fix: readme.

* fix example workflow labes

* add test for multiple label match

* add test for multiple label match

Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm added a commit that referenced this pull request Dec 28, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers

* Run ci for webhook

* fix terraform type

* fix formatting

* fix terraform type

* fix terraform type

* fix: some fixes.

* fix: readme.

* fix example workflow labes

* add test for multiple label match

* add test for multiple label match

Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm added a commit that referenced this pull request Dec 28, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers

* Run ci for webhook

* fix terraform type

* fix formatting

* fix terraform type

* fix terraform type

* fix: some fixes.

* fix: readme.

* fix example workflow labes

* add test for multiple label match

* add test for multiple label match

Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants