-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webhook): Support multiple arrays of tags is matchers. #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
npalm
changed the title
feat: Support multiple arrays of tags is matchers.
feat(webhook): Support multiple arrays of tags is matchers.
Dec 8, 2022
close #2715 |
@npalm, not sure if this PR gives an error on applying without commit 2ab5f46#diff-69a0e0ca008de526fb8fe2c1d1995d6632c16a9cd1bc58c9f58eec9ce1676f30! |
Tested the branch with the example for multi-runners, all works fine. |
GuptaNavdeep1983
approved these changes
Dec 13, 2022
npalm
added a commit
that referenced
this pull request
Dec 13, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers * Run ci for webhook * fix terraform type * fix formatting * fix terraform type * fix terraform type * fix: some fixes. * fix: readme. * fix example workflow labes * add test for multiple label match * add test for multiple label match Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm
added a commit
that referenced
this pull request
Dec 13, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers * Run ci for webhook * fix terraform type * fix formatting * fix terraform type * fix terraform type * fix: some fixes. * fix: readme. * fix example workflow labes * add test for multiple label match * add test for multiple label match Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm
added a commit
that referenced
this pull request
Dec 28, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers * Run ci for webhook * fix terraform type * fix formatting * fix terraform type * fix terraform type * fix: some fixes. * fix: readme. * fix example workflow labes * add test for multiple label match * add test for multiple label match Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm
added a commit
that referenced
this pull request
Dec 28, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers * Run ci for webhook * fix terraform type * fix formatting * fix terraform type * fix terraform type * fix: some fixes. * fix: readme. * fix example workflow labes * add test for multiple label match * add test for multiple label match Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
npalm
added a commit
that referenced
this pull request
Dec 28, 2022
* feat(multi-runner): Support multiple arrays of tags in matchers * Run ci for webhook * fix terraform type * fix formatting * fix terraform type * fix terraform type * fix: some fixes. * fix: readme. * fix example workflow labes * add test for multiple label match * add test for multiple label match Co-authored-by: navdeepg2021 <navdeepg2021@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the matcher to support multiple arrays of tags. This allow to match multiple set of tags on a single runner configuration. Useful to match for example
[self-hosted, ubuntu-latest]
and[self-hosted, ubuntu-2204]
on the same runner.