feat: Add option to disable Runner Syncer Lambda trigger #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
requested changes
Feb 24, 2023
There was a problem hiding this comment.
@anjosluc looks good, can you add the new variable also to the multi-runner module? See https://github.com/philips-labs/terraform-aws-github-runner/blob/main/modules/multi-runner/runner-binaries.tf
npalm
reviewed
Feb 24, 2023
added 3 commits
February 24, 2023 12:27
…com/anjosluc/terraform-aws-github-runner into feat/allow-syncer-trigger-disabling
…module, fix README.md
npalm
approved these changes
Mar 1, 2023
|
@anjosluc thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the module allows us to use Lambda functions to sync GitHub runner binaries on S3 automatically to the latest release available on actions/runners repository, but sometimes a release can have issues in their functionality that were not caught by Github prior to release it, so we need to rollback the binary distribution on S3 to a previous version and disable Lambda Syncer to stop checking for updates. This option allows us to quickly solve problems in runners version like we had in actions/runner#2435 by freezing automatic updates and still being able to use Runner Syncer.