-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runners): add option to prefix registered runners in GitHub #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update start scripts fix scripts refactor names and manage fixed tags via terraform
GuptaNavdeep1983
previously approved these changes
Mar 13, 2023
GuptaNavdeep1983
approved these changes
Mar 13, 2023
GuptaNavdeep1983
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3034
Description
This PR add the option to prefix the name registered in GitHub. By default no prefix will be used.
Now tags
ghr:runner_name_prefix
addedghr:created_by
added values eitherscale-up-lambda
orpool-lambda
Start scripts
For custom AMI's scripts can be updated to retrieve the AWS EC2 Tag
RunnerNamePrefix
Next the $runner_name_prefix can be combined with the instanceId the name. When you would like to add a seperator, add this to the terraform variable
runner_name_prefix
.Example of runners based on multi-runner example:
Verificaton
Deployed versions main, trigger builds. Next update to branch (rebuild lambda, and ensure runners are active). Next upgrade environment. Checked that old build runners are removed by scale-down, checked new build runners are removed by scale down.
Verififed for: