Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Support for Amazon Linux 2023 #3293

Closed
wants to merge 1 commit into from
Closed

feat: Add Support for Amazon Linux 2023 #3293

wants to merge 1 commit into from

Conversation

eabrouwer3
Copy link
Contributor

@eabrouwer3 eabrouwer3 commented May 25, 2023 •
edited
Loading

First attempt at resolving issue #2848. However, because the latest supported Amazon Linux version is now 2023, this PR has been updated to use al2023 by default.

@eabrouwer3 eabrouwer3 changed the title Add runner_amazon_linux_2022 option variable feat(Add Support for Amazon Linux 2022) May 25, 2023
@eabrouwer3 eabrouwer3 changed the title feat(Add Support for Amazon Linux 2022) feat: Add Support for Amazon Linux 2022 May 25, 2023
@eabrouwer3 eabrouwer3 mentioned this pull request May 25, 2023
Closed
@GuptaNavdeep1983
Copy link
Contributor

@eabrouwer3 can you resolve the issue with pipelines?

@npalm
Copy link
Member

npalm commented Jul 5, 2023

I think it would be better that we replace Amazon Linux 2 by default to 2022

@eabrouwer3
Copy link
Contributor Author

@npalm I agree, if we're ok with that. I'll update my PR to do that.

@eabrouwer3 eabrouwer3 changed the title feat: Add Support for Amazon Linux 2022 feat: Add Support for Amazon Linux 2023 Jul 5, 2023
@eabrouwer3
feat: Add Support for Amazon Linux 2022
8dacb38 
Add `runner_amazon_linux_2022` boolean variable

Get rid of amazon linux 2022 config option

Make PR changes even smaller

Update all references to amzn2. Also bump to al2023 (latest supported version)

Add the al2023 packer file
@eabrouwer3
Copy link
Contributor Author

@npalm I've checked my PR according to the CONTRIBUTING.md guidelines, squashed all my commits into one, and also updated the PR to bump up to al2023 instead of al2022 because that's the most current supported version. I couldn't find all the necessary details for the packer files for the al2022 versions. Let me know what you think and if I need to change/update anything else!

@GuptaNavdeep1983
Copy link
Contributor

@eabrouwer3 All the files relevant for packer are under images folder and the install/start scripts are under modules folder.

@eabrouwer3
Copy link
Contributor Author

@GuptaNavdeep1983, what I mean is that I couldn't find the al2022 AMI when searching in the EC2 console. And I needed to find that to double check the image name format, and get the owner for the packer file. I figured everything out for the al2023 image though.

@GuptaNavdeep1983
Copy link
Contributor

@eabrouwer3, are you able to build packer images after this change. In my initial investigation it seems that there are conflicts in existing installations vs the installations provisioned through the script.

image

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Aug 10, 2023
@eabrouwer3
Copy link
Contributor Author

Closing this PR in favor of making it on a new branch (made the PR off of my main, making it hard to sync with the forked repo's main).

@eabrouwer3 eabrouwer3 closed this Aug 16, 2023
@eabrouwer3 eabrouwer3 mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm Awaiting requested review from npalm

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eabrouwer3 @GuptaNavdeep1983 @npalm