fix(lambda): reuse http clients #3931
Open
+16
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchungy
commented
Jun 10, 2024
| @@ -1,8 +1,10 @@ | |||
| import { GetParameterCommand, PutParameterCommand, SSMClient, Tag } from '@aws-sdk/client-ssm'; | |||
| import { getTracedAWSV3Client } from '@terraform-aws-github-runner/aws-powertools-util'; | |||
|
|
|||
| let ssmClient: SSMClient; | |||
There was a problem hiding this comment.
As this is a lib, I don't want to create a new client on import, so we're caching a client only when the below functions are called;
There was a problem hiding this comment.
Alternatively, the caller should pass in a client
|
Thx for creating the PR. I thought that caching was not needed anymore with v3. I will check your PR next week. |
|
Have you seen that the canges made are breaking the tests? |
Interesting, I'll take a peek when I get some time 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating Http Clients per request is slow, as the client always has to re-establish a new connection with AWS. Not to mention, they're actually cause for concern when it comes to memory leaks, but fortunately with Lambdas they aren't long lived enough.
This PR changes the code to create single clients so we should see noticeable improvements with successive invocations of the Lambdas.
It's best practice to initialise these outside of the handler.