Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove outdated instruction from contribution guide #4065

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

janslow
Copy link
Contributor

@janslow janslow commented Aug 14, 2024

The process of updating the Terraform module documentation is now run on the main branch (example), so it no longer needs to be run on forked repositories (it also requires credentials for the GitHub App).

As per @npalm's comment, I'm removing this reference, to prevent any confusion for new contributors.

The process of updating the Terraform module documentation is now run on the `main` branch ([example](philips-labs#3919)), so it no longer needs to be run on forked repositories (it also requires credentials for the GitHub App).

As per @npalm's [comment](philips-labs#4063 (comment)), I'm removing this reference, to prevent any confusion for new contributors.
@npalm
Copy link
Member

npalm commented Aug 15, 2024

Can you provide a link to the failing job?

@npalm npalm self-requested a review August 15, 2024 07:40
@npalm
Copy link
Member

npalm commented Aug 15, 2024

see here an example of the docs update
#4067

@npalm npalm merged commit 01c1515 into philips-labs:main Aug 15, 2024
3 checks passed
@janslow janslow deleted the patch-1 branch August 17, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants