sync GitHub action distribution to S3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-runner into feature/distrubtion-syncer
gertjanmaas
requested changes
May 2, 2020
| import { handle } from './syncer/handler'; | ||
|
|
||
| module.exports.handler = async (event: any, context: any, callback: any): Promise<any> => { | ||
| const statusCode = await handle(); |
There was a problem hiding this comment.
StatusCode isn't necessary, this lambda isn't part of the API
Co-authored-by: Gertjan Maas <gertjan@maas.codes>
|
@gertjanmaas solved review comments, also add tagging for resources and update default example. Did not change the used API. The one you suggested is not a public api. |
gertjanmaas
approved these changes
May 6, 2020
npalm
added a commit
that referenced
this pull request
Aug 5, 2021
# This is the 1st commit message: Rebase # This is the commit message #2: fix: terraform error # This is the commit message #3: fix: terraform error # This is the commit message #4: fix: test and linter # This is the commit message #5: runner labels can be a subset # This is the commit message #6: runner labels can be a subset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid we have to download the github action dist everytime on runner is created we cach the dist in S3.