Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add udev to amp-devcontainer-cpp #572

Merged
merged 4 commits into from
Sep 17, 2024
Merged

feat: add udev to amp-devcontainer-cpp #572

merged 4 commits into from
Sep 17, 2024

Conversation

richardapeters
Copy link
Contributor

@richardapeters richardapeters commented Sep 16, 2024

Pull Request

Description of changes

This PR adds the udev package to amp-devcontainer-cpp to make device nodes and rules available to the container. This enables usage of attached hardware/embedded devices in the container. Examples are access to serial ports or debuggers for debugging and flashing.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@richardapeters richardapeters requested a review from a team as a code owner September 16, 2024 11:27
Copy link
Contributor

github-actions bot commented Sep 16, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:d4313b364c07c50fdef3133f1c11d98f1d71f9606832cc096142400616354bcc

OS/Platform Previous Size Current Size Delta
linux/amd64 433.13M 433.13M 0.00 (+0.00%)
linux/arm64 572.34M 572.34M 0.00 (+0.00%)

Copy link
Contributor

github-actions bot commented Sep 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.09s
✅ DOCKERFILE hadolint 2 0 0.44s
✅ JSON prettier 16 1 0 0.74s
✅ JSON v8r 15 0 19.24s
✅ MARKDOWN markdownlint 8 0 0 1.03s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.25s
✅ REPOSITORY checkov yes no 15.9s
✅ REPOSITORY gitleaks yes no 0.37s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.19s
✅ REPOSITORY secretlint yes no 1.31s
✅ REPOSITORY trivy yes no 6.29s
✅ REPOSITORY trivy-sbom yes no 1.11s
✅ REPOSITORY trufflehog yes no 3.06s
✅ SPELL lychee 55 0 1.03s
✅ YAML prettier 21 0 0 1.09s
✅ YAML v8r 21 0 12.37s
✅ YAML yamllint 21 0 0.57s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

.devcontainer/cpp/Dockerfile Fixed Show fixed Hide fixed
.devcontainer/cpp/Dockerfile Fixed Show fixed Hide fixed
Copy link
Contributor

github-actions bot commented Sep 16, 2024

Test Results

 2 files  ±0   2 suites  ±0   52s ⏱️ ±0s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 30c38bc. ± Comparison against base commit ac2c8d6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 16, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:a05490c6b7fce8c3a4f0117eac71af29fefceae5d6820df50f286d8824b65a16

OS/Platform Previous Size Current Size Delta
linux/amd64 641.11M 653.79M 12.68M (+1.98%)
linux/arm64 633.45M 646.22M 12.77M (+2.02%)

@rjaegers rjaegers changed the title feat: install udev feat: add udev to amp-devcontainer-cpp Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

@rjaegers rjaegers added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit ebe907e Sep 17, 2024
22 checks passed
@rjaegers rjaegers deleted the feature/udev branch September 17, 2024 14:21
Copy link
Contributor

Pull Request Report (#572)

Static measures

Description Value
Number of added lines 1
Number of deleted lines 0
Number of changed files 1
Number of commits 4
Number of reviews 3
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 1.1 Days
Time that was spend on the branch before the PR was created 20 Sec
Time that was spend on the branch before the PR was merged 1.1 Days
Time to merge after last review 2 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 2.2 Hours
Total time spend in last status check run on PR 5.2 Hours

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants