Changes Time.now to Time.utc which is more correct

philnash · Aug 18, 2019 · 79651eb · 79651eb
1 parent 36fbda7
commit 79651eb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/spec/crotp/totp_spec.cr b/spec/crotp/totp_spec.cr
@@ -87,7 +87,7 @@ describe CrOTP::TOTP do
       totp = CrOTP::TOTP.new(secret)
 
       it "verifies the current time" do
-        totp.verify(totp.generate, at: Time.now).should be_true
+        totp.verify(totp.generate, at: Time.utc).should be_true
       end
 
       results[:sha1].each do |(time, result)|
@@ -109,7 +109,7 @@ describe CrOTP::TOTP do
       totp = CrOTP::TOTP.new(secret, algorithm: OpenSSL::Algorithm::SHA256)
 
       it "verifies the current time" do
-        totp.verify(totp.generate, at: Time.now).should be_true
+        totp.verify(totp.generate, at: Time.utc).should be_true
       end
 
       results[:sha256].each do |(time, result)|
@@ -131,7 +131,7 @@ describe CrOTP::TOTP do
       totp = CrOTP::TOTP.new(secret, algorithm: OpenSSL::Algorithm::SHA512)
 
       it "verifies the current time" do
-        totp.verify(totp.generate, at: Time.now).should be_true
+        totp.verify(totp.generate, at: Time.utc).should be_true
       end
 
       results[:sha512].each do |(time, result)|

diff --git a/src/crotp/totp.cr b/src/crotp/totp.cr
@@ -12,7 +12,7 @@ module CrOTP
       end
     end
 
-    def generate(at : Int = Time.now.to_unix) : String
+    def generate(at : Int = Time.utc.to_unix) : String
       counter = at // PERIOD
       generate_otp(counter)
     end
@@ -21,7 +21,7 @@ module CrOTP
       generate(at.to_unix)
     end
 
-    def verify(token : String, at : Int = Time.now.to_unix, allowed_drift : Int = 0) : Bool
+    def verify(token : String, at : Int = Time.utc.to_unix, allowed_drift : Int = 0) : Bool
       counter = at // PERIOD
       Array.new(allowed_drift + 1) { |i| verify_otp(token, counter - i) }.any?
     end