Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL 2 migration, grabbing mouse now works much better #24

Merged
merged 3 commits into from
Oct 24, 2020

Conversation

agentbooth
Copy link
Contributor

Hey Phil. This worked fine for me on my linux PC, would be good to test on other environments. I'd like to test on my Raspberry Pi. There is likely a better optimized version of the surface/texture handling, but this basic conversion seemed to work. Grabbing the mouse with F10 works much better which was a nice bonus. I didn't run into an issue with the timers, just had to change the type of the timer callbacks.

@philpem philpem merged commit 5d369b9 into philpem:master Oct 24, 2020
@philpem
Copy link
Owner

philpem commented Oct 24, 2020

Nice work! Merged!

Looks like this paves the way for #7, which would move the LEDs down, perhaps make them larger, and add icons for floppy and hard drive access too.

@agentbooth
Copy link
Contributor Author

Hey Phil -- thanks for getting this merged. There is probably a more optimized version of the SDL2 implementation but I don't know enough about the SDL details to address that. Also might be some issues with the Alpha channel on some systems but correctly worked on Raspberry Pi, and my linux x86. I have the LED's as 16x16 (instead of the 8x8 checked in) if you'd prefer the larger icons. I also can check in the source .png image if you want to let me know where to put it.

@philpem
Copy link
Owner

philpem commented Oct 24, 2020

I think optimisation can wait until later, getting it working is always the priority for me. That ignores the obvious caveat of it being usable!

Alpha channel - I haven't seen any issues on x86_64 Linux, if that's an issue I'm sure someone will raise it :)

Re larger LEDs - feel free to check that in on another PR, but I think it'd need to be done more like a status line. 16x16 times four LEDs would cover a fair bit of the bottom corner of the screen. This might also reduce the impact of any alpha-channel issues.

@agentbooth
Copy link
Contributor Author

Ah yes, I remember now -- that's why I went to 8x8 instead of the original 16x16 so it would obscure less of the bottom right corner. 16 pixel status bar in the future sounds like a good plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants