Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to convert node tree back to HTML #33

Merged
merged 2 commits into from
Oct 7, 2015
Merged

Add function to convert node tree back to HTML #33

merged 2 commits into from
Oct 7, 2015

Conversation

glaucocustodio
Copy link
Contributor

No description provided.

@glaucocustodio glaucocustodio mentioned this pull request Oct 6, 2015
raw_html(tail, html <> tag_for(elem, attrs, value))
end

def tag_attrs(attr_list) do
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function could be private.

@philss
Copy link
Owner

philss commented Oct 7, 2015

@glaucocustodio

I added some comments in the PR. Please check.
Also, I think you could change the variable name of first_dom to node, in order to keep consistency.

This is a very nice feature, thanks! 😃

@glaucocustodio
Copy link
Contributor Author

Nice. I thought about keeping these functions you mentioned as private, but I didn't do in order to test them..
Anyway, I will do the requested changes. Thanks for the tips!

philss added a commit that referenced this pull request Oct 7, 2015
Add function to convert node tree back to HTML
@philss philss merged commit 263f0e5 into philss:master Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants